From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11895 invoked by alias); 22 Mar 2018 18:24:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11723 invoked by uid 89); 22 Mar 2018 18:24:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 18:24:20 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2MIO6tj109580 for ; Thu, 22 Mar 2018 14:24:14 -0400 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gvfrkwgnd-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Thu, 22 Mar 2018 14:24:13 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Mar 2018 12:24:11 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 22 Mar 2018 12:24:10 -0600 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2MIOAPB11534782; Thu, 22 Mar 2018 11:24:10 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 08EE16E038; Thu, 22 Mar 2018 12:24:10 -0600 (MDT) Received: from otta.local (unknown [9.85.154.167]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id 377BD6E03A; Thu, 22 Mar 2018 12:24:09 -0600 (MDT) Subject: Re: [PATCH,rs6000] GCC -7, no swap optimization for vpermxor instruction To: Carl Love Cc: Segher Boessenkool , gcc-patches@gcc.gnu.org, David Edelsohn , Bill Schmidt References: <1521733713.4859.16.camel@us.ibm.com> From: Peter Bergner Date: Thu, 22 Mar 2018 18:35:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521733713.4859.16.camel@us.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18032218-0028-0000-0000-000009567031 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008724; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000255; SDB=6.01006856; UDB=6.00512679; IPR=6.00786143; MB=3.00020184; MTD=3.00000008; XFM=3.00000015; UTC=2018-03-22 18:24:11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18032218-0029-0000-0000-00003A12599C Message-Id: <19f59e09-1537-29ed-b3bf-896ce4b38164@vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-22_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803220210 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg01230.txt.bz2 On 3/22/18 10:48 AM, Carl Love wrote: > Backport: UNSPEC_VPERMXOR fix from mainline commit 258530: > 2018-03-21  Carl Love   > > * config/rs6000/r6000.c (rtx_is_swappable_p): Add case UNSPEC_VPERMXOR. > > gcc/testsuite/ChangeLog: > > 2018-03-21  Carl Love   > * gcc.target/powerpc/crypto-builtin-1-runnable.c: New test file. Still not the right syntax. From the URL I provided you, it shows your ChangeLog entries for your backport should look like: gcc/ChangeLog: 2018-03-22 Carl Love Backport from mainline 2018-03-14 Carl Love * config/rs6000/rs6000-c.c: Add macro definitions for ALTIVEC_BUILTIN_VEC_PERMXOR. * config/rs6000/rs6000.h: Add #define for vec_permxor builtin. * config/rs6000/rs6000-builtin.def: Add macro expansions for VPERMXOR. * config/rs6000/altivec.md (altivec_vpermxor): New define expand. * config/rs6000/rs6000-p8swap.c (rtx_is_swappable_p): Add case UNSPEC_VPERMXOR. * config/doc/extend.texi: Add prototypes for vec_permxor. gcc/testsuite/ChangeLog: 2018-03-22 Carl Love Backport from mainline 2018-03-14 Carl Love * gcc.target/powerpc/builtins-7-runnable.c: New test file. So basically, you cut/paste the entire ChangeLog entry from the trunk ChangeLog file, including the date stamp (tabbed over) with the line "Backport from mainline" added. You then add a new date stamp which is the date you commit the patch. If you post a patch with a date stamp and you commit it a different day, you need to update the date stamp. Most people leave the date stamp (not the one after the Backport from mainline) out of their patch submissions, since they don't know ahead of time when they will commit it. Peter