From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22077 invoked by alias); 28 Apr 2017 19:01:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22041 invoked by uid 89); 28 Apr 2017 19:01:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:e4271f5, Hx-spam-relays-external:74.125.82.66, H*MI:sk:e4271f5, H*RU:74.125.82.66 X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 19:01:45 +0000 Received: by mail-wm0-f66.google.com with SMTP id u65so12624767wmu.3 for ; Fri, 28 Apr 2017 12:01:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=4P7AkVYIwJ2WExZdINtL45Rm1U+3AWxfcLaoO7V2ac8=; b=VkGsLybV3hRa2G0xd1zS5g/unH7ySnkYrRkCQyTOO5sSB4wyzqNHPOMnT8gI6xOzHl m/Yk9mt2w/QHwacKF+cj/m+gQcDBKhMhxawwGz1OU0tyBMOpZL3LmWqJqKaPJBTf4neZ V2ESzYp+OLpVw7aMCOAwL+QrkfoSMIOR2GpwgaULlr7t86XTYPDNzyhL0fJZz1qzKW+r qUHg+eE5pDLR4YzR4mNOvTKGkSrk3rEnZU9Wa7xrUkY97pEPoexhEjG/+AsxHOFd+dXF TpnLCXtVQSjpvwdo6yhIYfbw8MWAeMNeFIM0YdWr+pyXEjoEjtFEOx2JIa8nxQmRjU1K fDBA== X-Gm-Message-State: AN3rC/6b9LxmExi2TDXl9ObSVAEJVeek55fC+CKEqGNMS0mI6R3PuXRU HU8WFdEYlyEt4w== X-Received: by 10.28.5.72 with SMTP id 69mr7037660wmf.59.1493406106095; Fri, 28 Apr 2017 12:01:46 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id y3sm764688wrd.23.2017.04.28.12.01.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 12:01:45 -0700 (PDT) Subject: Re: [PATCH 3/8] Simplify representation of locations of a block. To: Martin Sebor , Nathan Sidwell , marxin , gcc-patches@gcc.gnu.org References: <4f99730aa8b94384864c11e9026bcb9036d121e7.1493371589.git.mliska@suse.cz> <00fc8b09-85b6-eae2-e439-410b76e16f92@acm.org> Cc: hubicka@ucw.cz From: Pedro Alves Message-ID: <19f773c0-e844-1f9f-9382-b5c0c704ec63@palves.net> Date: Fri, 28 Apr 2017 19:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg01530.txt.bz2 On 04/28/2017 05:28 PM, Martin Sebor wrote: > On 04/28/2017 05:47 AM, Nathan Sidwell wrote: >>> @@ -427,9 +429,31 @@ static void output_lines (FILE *, const source_t >>> *); >>> static char *make_gcov_file_name (const char *, const char *); >>> static char *mangle_name (const char *, char *); >>> static void release_structures (void); >>> -static void release_function (function_t *); >>> extern int main (int, char **); >>> +function_info::function_info () >>> +{ >>> + memset (this, 0, sizeof (*this)); >> >> EW. ok with a comment about function_info's c++11's PoDness. > > Unless it's some other kind of vector, the patch adds a vector > member to the class, which makes it not a PoD.(*) Funny, just this week we added this to gdb to catch such misuses at compile time: https://sourceware.org/ml/gdb-patches/2017-04/msg00378.html https://sourceware.org/ml/gdb-patches/2017-04/msg00381.html Thanks, Pedro Alves