public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org
Cc: rguenther@suse.de, richard.sandiford@arm.com,
	Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
Subject: Re: [PATCH V6] VECT: Apply LEN_MASK_{LOAD,STORE} into vectorizer
Date: Fri, 23 Jun 2023 09:55:43 +0200	[thread overview]
Message-ID: <1BCB095A-85C7-4B27-B87B-368279BBEC8D@gmail.com> (raw)
In-Reply-To: <20230622235112.9407-1-juzhe.zhong@rivai.ai>

On 23 June 2023 01:51:12 CEST, juzhe.zhong@rivai.ai wrote:
>From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>

I am sorry but I somehow overlooked a trivial spot in V5.
Nit which does not warrant an immediate next version, but please consider it before pushing iff approved:

>+	      if (final_len)
>+		{
>+		  signed char biasval
>+		    = LOOP_VINFO_PARTIAL_LOAD_STORE_BIAS (loop_vinfo);
>+
>+		  bias = build_int_cst (intQI_type_node, biasval);
>+		}
>+
>+	      /* Arguments are ready.  Create the new vector stmt.  */
>+	      if (final_len)
>+		{

Fuse the block below into the one above as the condition seems to be identical?
thanks,

>+		  gcall *call;
> 		  tree ptr = build_int_cst (ref_type, align * BITS_PER_UNIT);
> 		  /* Need conversion if it's wrapped with VnQI.  */
> 		  if (vmode != new_vmode)

  reply	other threads:[~2023-06-23  7:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 23:51 juzhe.zhong
2023-06-23  7:55 ` Bernhard Reutner-Fischer [this message]
2023-06-23  8:03   ` Richard Sandiford
2023-06-23  8:37     ` 钟居哲
2023-06-23  9:38     ` Bernhard Reutner-Fischer
2023-06-24  0:53       ` Li, Pan2
2023-06-23  8:08 ` Richard Sandiford
2023-06-23  8:10   ` 钟居哲

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1BCB095A-85C7-4B27-B87B-368279BBEC8D@gmail.com \
    --to=rep.dot.nop@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=rguenther@suse.de \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).