public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mikestump@comcast.net>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Alexandre Oliva <oliva@adacore.com>,
	Rainer Orth <ro@cebitec.uni-bielefeld.de>
Subject: Re: wrap math.h for M_PI et al in target/i386 tests
Date: Mon, 05 Aug 2019 15:52:00 -0000	[thread overview]
Message-ID: <1C541B41-E8CC-4E0A-8924-72F44BA5FF14@comcast.net> (raw)
In-Reply-To: <CAFULd4Y_aaS4c+CM2S+e-PGtzf4g62Du_XCR6n5zV-VEG+8uyA@mail.gmail.com>



> On Jul 30, 2019, at 5:22 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> Most but not all of the tests that expect M_PI, M_PI_2 and/or M_PI_4
>> to be defined in math.h explicitly exclude one target system that does
>> not satisfy this non-standard assumption.
>> 
>> This patch introduces a wrapper header that includes math.h and then
>> conditionally supplies the missing non-standard macro definitions.
>> With that, we can drop the dg-skip-if "no M_PI" exclusions.
>> 
>> for  gcc/testsuite/ChangeLog
>> 
>> * gcc.target/i386/math_m_pi.h: New.
> 
> LGTM, patch also needs approval from testsuite maintainer (CC'd).

Not unreasonable for the x86 maintainer to approve patches like this.  It doesn't impact any non-386 target.

Ok.

  reply	other threads:[~2019-08-05 15:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 12:50 Uros Bizjak
2019-08-05 15:52 ` Mike Stump [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-07-18  0:26 Alexandre Oliva
2019-07-30  8:50 ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1C541B41-E8CC-4E0A-8924-72F44BA5FF14@comcast.net \
    --to=mikestump@comcast.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=oliva@adacore.com \
    --cc=ro@cebitec.uni-bielefeld.de \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).