From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id B52C43858D28 for ; Wed, 15 Feb 2023 19:30:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B52C43858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31FIi98d004583; Wed, 15 Feb 2023 19:30:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=dMnbgSum8cNjmOrVn74fhGZocDcqbtLZ7uAst+0ocUM=; b=ogTLSs0If0RIWOlb7TwnQi/il5I3V7XbQrR2uf+/XvUGu3PXUvsfx2V8L33YHk2BuHi6 OfjQdiAmLQC4Nmq/kcUVpIDaKpzY4rnPrI1sbkGZ1NPh4AtG6ymOgyrYq7pnifZ+Wo/U xf+6kFsrHJ+x0t0lbVcjTY5eXhl4ukjm/gNc/gTJBs6LL2ppjcHpYsVsc+qENx8VSMzP Q5zl9fjBPLYumz6+T00iLgpErufx2A1ltLWRWKON7jmgMFf0t3ioGP+psrURB1kqyk22 k2wjvyA9AtQYXc2TBHkOOhIkdOtbXvXtFHd8exGP380+utDHUjEhmL/3r0okU8bAnt3c eQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np1t3h72u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Feb 2023 19:30:03 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31FJPV5Y003548; Wed, 15 Feb 2023 19:30:02 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2171.outbound.protection.outlook.com [104.47.57.171]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f7ksqe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Feb 2023 19:30:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=STlxouKMMvDSTl1jzMj0ZVZ7QAdNK2Q7COwaiRe1jQiqLJLR7FN/0FrPo4rjShuPOR/Bd29S4F8BFSY84fcot/8npJbcYj+8Jb/q7LaxJu/BHy99sT5QDT1h688eV8OAfrUEEdPtQCjedDjQM54hdHQ7oNmyIQgh54Gy0B91Qmel/rM7EYFy69Hc/SdV3EmA6hQ8KfU3vK4+MNMUnkSyMRKBF49bzD7j+l//E1kpVC3WrNITTYkbokSPGl/EjaU0pmPvlZPkbrnEpVW6Lde+Eg6fiSh+G1wl691kw8Uo2EmvIWijLY+9Yqf3fpcFvT2dExOCsftGR0jNpCpQ3gZHFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dMnbgSum8cNjmOrVn74fhGZocDcqbtLZ7uAst+0ocUM=; b=Uzquq7MPAMR4AGY1Qe/VsLH2zXqQqCTGthkp6uCskhF8adaIwqM4qDmd8tEtkaAI9VnSsNHAkaMq2OPSrq6qVFRZlGFf3G6b5L84n/Ge7LuFBvTkEsBRYRcKtHbe+0X7pihpmYrz8lZHifaHviSDW9gJRBB3qr3sxKZ4G/V3+BRW/Kl4S05ZfOVuLQsnI76UHf2+y0prdWTdTP01w/NsQGKKgfToKllzxSnT5eEJiQO6wteZPIg7pdR+XDLgV+fIjtK4uelIBPwxQJzqZUkSVX/wUGQ9bZ8xx3G6Jd2f8EITAe+sYa+cjLhNfW/h2l0/I11kVCPA0SYF4gLU+45TIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMnbgSum8cNjmOrVn74fhGZocDcqbtLZ7uAst+0ocUM=; b=HFTjndEsBM+epxTqapO/njS2WxMP8z2uYdRAMS4JfCXuBfO19T2JkQy1xTCVSzA0PxrAC2b4KDzrUBwP4UIxE6btpGkAfegJd3av5rNXrKL6pptOnM4zkHXAUcL2RHU3c5M8m/VMsV8LcCA4MQ5LSQWD3sSI5FjCD/RkZDTyL3s= Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by BN0PR10MB4981.namprd10.prod.outlook.com (2603:10b6:408:12d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Wed, 15 Feb 2023 19:30:00 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::7030:ed2e:20d0:cd5b]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::7030:ed2e:20d0:cd5b%7]) with mapi id 15.20.6111.010; Wed, 15 Feb 2023 19:30:00 +0000 From: Qing Zhao To: Hans-Peter Nilsson CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] testsuite: Handle "packed" targets in c-c++-common/auto-init-7.c and -8.c Thread-Topic: [PATCH] testsuite: Handle "packed" targets in c-c++-common/auto-init-7.c and -8.c Thread-Index: AQHZQXKCRDVbqU/pfkK2WFJquKcLi67QZOIA Date: Wed, 15 Feb 2023 19:30:00 +0000 Message-ID: <1C9277DB-4450-4484-A77A-F30BCBA0C628@oracle.com> References: <20230215191957.F12532042E@pchp3.se.axis.com> In-Reply-To: <20230215191957.F12532042E@pchp3.se.axis.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR10MB4344:EE_|BN0PR10MB4981:EE_ x-ms-office365-filtering-correlation-id: e8c0a58d-39e5-4087-13b3-08db0f8b0753 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EFycAD6mcXajyki8Ex4BvVYyN4mc07i1vDwvjm3o3SopwHLnWbVfbnq/CNwU6aJWdU31xHastjJv5cDPK8cNaT+HFZEonbDOB8DYLLSKs+H/+FIlHBPTYTKSUNjesVetjLm4Ur01uDQ2QbB+QNoDJOOva0tcjI5Yvo871EKGFYBr3P/CkXHiJDLj9KfDk9VSLIoq5g/JJETs8+ZmFZsUtZjhZWP77ruL1yKuJaXLOjD2qK7Zrm5HhCFZmJvyk2aN0XUI3rWq07ayTFfBNp62mjsJqKYbysGDWtRZZHrWdbsWiUmRVbznIst9DXGQCUOWlhqHivaJ0MCpfj+QiwMyWq0CxlLnhOqoGzvecKH3jQVrYCfj/r2FVdrfdrjgFFtTYhq9vwK2DcU00Jdh9kNbKN9oA3C2RCesnaVZl02IgoBSnijGLKaRlnfHqe5vUHTV4GhSaBvPkrj5BvFd5sTP3IDE8Po7aMSobBv8CKOlXxjRjO+F76A1RBZ/iZ+ke+vOQi1d8JN1j/VZqDv7uzDhRG0/+j03JGTx563Zy1rdbG/zUCMMWUiMiynbRu2D52L0sehh+ih8pvYwXNUv+Ycdx7jXw+rSKwXlZlAS0lMYEPIhh4hSFOfmTW7pS+epydeRgE2/OlTTAOgl7vlISfiJao+dK7/0mNuF8YCY+CrxDG5OpcPjmGrVkmZm+R1JEMP07vGvVZbh6XjuGC60BvRKQA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4344.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(136003)(39860400002)(396003)(376002)(451199018)(26005)(966005)(6506007)(6486002)(478600001)(6512007)(186003)(38100700002)(71200400001)(53546011)(83380400001)(122000001)(33656002)(2616005)(2906002)(41300700001)(86362001)(4326008)(36756003)(38070700005)(8676002)(6916009)(64756008)(66446008)(66946007)(66476007)(66556008)(76116006)(316002)(91956017)(44832011)(8936002)(5660300002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jNnqDI5fuZbj75Lsqfqt7JG4qqtvTd7lfL7kUyF2utBkARObxx1IK73QsdBZ?= =?us-ascii?Q?NG2+NUY/ySACHWY8CTyZdk6SOdT8iBJN7vQWo55y2IkRS5+yh7A+MrB1547D?= =?us-ascii?Q?/cduuJcIZ2Y6M+Qt96mIvAJ5xjVJcSIs7kF34EcozgExhQpoV+tmcCo3jhT0?= =?us-ascii?Q?LaIEb451UyvwD7XOGjQIFHgh1ymF7aCOHYa9+fbUcMeklE3nNlmV86pQ5wjp?= =?us-ascii?Q?CpJkvgB6h27G+QM3jsPsfe/5fU9YGLvOJLSS1dzvZSMqGwZQqIgpTV1yS+BS?= =?us-ascii?Q?X1VWjtMpcxgzeBW+B+JRoFGBCrV4gGnegNcWSG+bCdpkhetIBhFHHwCZ6RBo?= =?us-ascii?Q?MsdDVw0E50wuZtXSkAVu55u6j6nKUsX7X9JUmpnKwoVV/3D0IVYsR5PfUYx8?= =?us-ascii?Q?T6RdJbAWsS7/9HOgSPMBoXDuDCCXlKcKsgA4c5Bl/m3f07cdg2IGp5VIThPk?= =?us-ascii?Q?9okf4ZYRY2PzyXJ9Rwh9gBwx4QxbMXxGbxrv8lpCVVZKIAyS/fwn1VXkHSH9?= =?us-ascii?Q?QHjt9Rva7OqvAuc0lzt1FuC6ZZulCEU2msrliPjJpOZzW6uPNiJOLs9SkBio?= =?us-ascii?Q?DjVd4ylYepGJ4yWQYC9n6EVKHrQSRnAL7yo7A4uqJXRbD6xTiFOuTZmKEeAj?= =?us-ascii?Q?mW7A98vZRpZjN25EhU0ZFcSPOGps6zKADVW2qIJ+fE3ueQ0mpaUVatC2srNp?= =?us-ascii?Q?kRnW/IG7hEcjZNaAyBJSdhaohumTWpEz3MWwh+JMl0X0Sye3KmFallspng3e?= =?us-ascii?Q?Y8m4TGRuxPmL88UcRDjSwaJ9FzIrsOnSXeUHOvfC8pr1drVMt/wGk3LhSoSp?= =?us-ascii?Q?wXCaMeZD9F/5mSrWkOHx+qhumTNaAxmIxRyiY765yrYgConvgJIGKiXIicaQ?= =?us-ascii?Q?BDwf++bQzgpoOh+jGXNIC6LQejAhBl/FH5MLipYR1BwRB25I0P2LN97yS1Om?= =?us-ascii?Q?pbRBhA6g5BnZH091IXjTOsab1JfWk1opCppwBhP6uea1ALv/mtENm/sKqyP2?= =?us-ascii?Q?1SphkH/2/ysKqO1fxccpI1bS1odJ4g+5b1uekqIFCYHHiEdoA7rWM6P5sI94?= =?us-ascii?Q?v7/kPZ5YivR81/e1TgtaUVkMQLnpalj8hFi7l3D8L4UzlkbxMTuIY+1I+geV?= =?us-ascii?Q?hEi+kxypzxupuW1SRtoTP2mBz91WWgRKIFMK4xzPBH5WMi/huHK/ptozgulG?= =?us-ascii?Q?2wdZfpSlyVzkzDaMNRYc3uxRUyGnC1S+6fBrIwPLnmocAS6XRTSal4fnGjML?= =?us-ascii?Q?WUum+skXzwKKrM/gc2ciWnTxoPsekG+wCAQX68bQlIWfn4PHfrhNV6n/ZR1q?= =?us-ascii?Q?pcg6tanVGX6Fdxi3rrmyJ2F7TGuACwsEM+hfVj/MgkfWH4oSeAL4nsVGM4vr?= =?us-ascii?Q?8NKanVSd3QJ4DiBYiCoLSJIJpW8MLCnF75QEpa9dcOo7++IadWjs7Odrb3KA?= =?us-ascii?Q?RnUzFKJZ7VMPcLt+FSc2ruB1IzBZh9Bu9jszeofg5QsogQqtmrK2A6lwcehW?= =?us-ascii?Q?h2B3l3JXJJelldkR+0TfnL21G/W7g1fesp/xpb8GcHTXOUjS50H2WIZwfWd8?= =?us-ascii?Q?pqKLZoOndJC+3EGmAOovRc/15H+f+IvhZoshXRAsQxO9qf1L6Y7Dv3rXv2yt?= =?us-ascii?Q?pw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 45pnNSxfqxSYpYUkmB2AZ8Qof4I3zPX3MBPh2SHdzgC2MZMseWCKtsSF56iGfoPI0ZS2QUQ6cOPISphiJH1t5aZI9+sj9qM9B31H9sPahKmm+O1qo55AMxyzuSsuloxCD+E5BzXQdfJ64HgXohqRWRs/e7Y97exqGXW+okYJDLN/enfYIUCqIDd8vWp1NB7pZSwZryuMED0tNZzjl5eRA73lSV0H5DPHwZUEkb7BymKloxcuzRrOGrBk4uVY/G9HBgvZla8W+zjHOHjmrV+bPAqG6ZHDmHBoSXjZbSNneOL/zUriY4aXjB6LSJots2rd+GX9K6K5i+c07lcR/s5ZRGeQ/eIbcZKzHsO6f222jO2Iu/V8uSzqsTu85sZoVsUtuJ6XF2FvML++llG8+X18rZTVe5EgEG8md8u9QmHZxNqntcECVBtRz5J89atAuFZ1OYTZqdBveSRro5YJUOrrEZV3An5SVf5blW1k/IbbxTgZzXAmm1OHABNaMRsu6pIm4ywhQZw2ZM5v2TkiWK0kWsYEV9JH6nhF8U9tNGBJjQ/Xx5UNciw/Xae7Wnp0BoQzfJoLQFmxqy2JbfJDTKO9jR6DI/VjsVlWJWyPjLLtpnWbPZnictVwe7NGpWg2qFKamk/4evEpU5TS/BHcDkaud8ZTWud76NJs0iY1NDGImWUJVBWoEPHPxbpIvlpzZKPFAbcAZWP8zD9xCEjUIznoKHk73NX6EFRwRgtqI+vqa8Orl2YODePar5Dxbv/pQcxV3uN1VZBG2Ee4a3ZCdfV2ww== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8c0a58d-39e5-4087-13b3-08db0f8b0753 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2023 19:30:00.0188 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: acK3X9SPxiuqCltvTuNmtWBkKLOsPInDnP6zZ+9nZAN8XLGjUlMSavAwuB2mUrCxGDNnKU78SSkBt4WKsDQNUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4981 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-15_10,2023-02-15_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302150171 X-Proofpoint-GUID: KVquOyO8xmb76ejCRDH2gdPcvQMJ0c11 X-Proofpoint-ORIG-GUID: KVquOyO8xmb76ejCRDH2gdPcvQMJ0c11 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thank you for fixing this issue. Qing > On Feb 15, 2023, at 2:19 PM, Hans-Peter Nilsson wrote: >=20 > Tested for cris-elf. Ok to commit? >=20 > -- >8 -- > Looks like there's a failed assumption that > sizeof (union U { char u1[5]; int u2; float u3; }) =3D=3D 8. > However, for "packed" targets like cris-elf, it's 5. >=20 > These two tests have always failed for cris-elf. I see from > https://gcc.gnu.org/pipermail/gcc-testresults/2023-February/777912.html > that they fail on pru-elf too, but I don't know if the cause > (and/or remedy) is the same. >=20 > IMHO this is preferred over the alternative; splitting up > that last line into two lines, like: > /* { dg-final { scan-tree-dump "temp4 =3D \ > .DEFERRED_INIT \\(8, 2, \&\"temp4\"" "gimple" { target { ! default_packed= } } } } */ > /* { dg-final { scan-tree-dump "temp4 =3D \ > .DEFERRED_INIT \\(5, 2, \&\"temp4\"" "gimple" { target default_packed } }= } */ >=20 > gcc/testsuite: > * c-c++-common/auto-init-7.c, c-c++-common/auto-init-8.c: Also > match targets where sizeof (union U) =3D=3D 5, like "packed" targets. > --- > gcc/testsuite/c-c++-common/auto-init-7.c | 2 +- > gcc/testsuite/c-c++-common/auto-init-8.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/gcc/testsuite/c-c++-common/auto-init-7.c b/gcc/testsuite/c-c= ++-common/auto-init-7.c > index b44dd5e68ed1..dd48d691596f 100644 > --- a/gcc/testsuite/c-c++-common/auto-init-7.c > +++ b/gcc/testsuite/c-c++-common/auto-init-7.c > @@ -32,4 +32,4 @@ double foo() > /* { dg-final { scan-tree-dump "temp1 =3D .DEFERRED_INIT \\(12, 2, \&\"te= mp1\"" "gimple" } } */ > /* { dg-final { scan-tree-dump "temp2 =3D .DEFERRED_INIT \\(24, 2, \&\"te= mp2\"" "gimple" } } */ > /* { dg-final { scan-tree-dump "temp3 =3D .DEFERRED_INIT \\(28, 2, \&\"te= mp3\"" "gimple" } } */ > -/* { dg-final { scan-tree-dump "temp4 =3D .DEFERRED_INIT \\(8, 2, \&\"te= mp4\"" "gimple" } } */ > +/* { dg-final { scan-tree-dump "temp4 =3D .DEFERRED_INIT \\((8|5), 2, \&= \"temp4\"" "gimple" } } */ > diff --git a/gcc/testsuite/c-c++-common/auto-init-8.c b/gcc/testsuite/c-c= ++-common/auto-init-8.c > index 739ac0289315..863f2ba87d7d 100644 > --- a/gcc/testsuite/c-c++-common/auto-init-8.c > +++ b/gcc/testsuite/c-c++-common/auto-init-8.c > @@ -32,4 +32,4 @@ double foo() > /* { dg-final { scan-tree-dump "temp1 =3D .DEFERRED_INIT \\(12, 1, \&\"te= mp1\"" "gimple" } } */ > /* { dg-final { scan-tree-dump "temp2 =3D .DEFERRED_INIT \\(24, 1, \&\"te= mp2\"" "gimple" } } */ > /* { dg-final { scan-tree-dump "temp3 =3D .DEFERRED_INIT \\(28, 1, \&\"te= mp3\"" "gimple" } } */ > -/* { dg-final { scan-tree-dump "temp4 =3D .DEFERRED_INIT \\(8, 1, \&\"te= mp4\"" "gimple" } } */ > +/* { dg-final { scan-tree-dump "temp4 =3D .DEFERRED_INIT \\((8|5), 1, \&= \"temp4\"" "gimple" } } */ > --=20 > 2.30.2 >=20