From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-315306-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8826 invoked by alias); 20 Mar 2012 16:06:49 -0000
Received: (qmail 8817 invoked by uid 22791); 20 Mar 2012 16:06:47 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Mar 2012 16:06:33 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id AE47E29009A;	Tue, 20 Mar 2012 17:06:35 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id 07-RdbEIRMtr; Tue, 20 Mar 2012 17:06:35 +0100 (CET)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id 80EBD290098;	Tue, 20 Mar 2012 17:06:35 +0100 (CET)
Subject: Re: [Patch/cfgexpand]: also consider assembler_name to call expand_main_function
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: text/plain; charset=windows-1252
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <alpine.LNX.2.00.1203201701230.4662@zhemvz.fhfr.qr>
Date: Tue, 20 Mar 2012 16:06:00 -0000
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Eric Botcazou <ebotcazou@adacore.com>, Jan Hubicka <jh@suse.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1D9E2C16-3989-438E-8016-837DC2E7021C@adacore.com>
References: <875C6F56-7161-48DF-91FB-3A01891F8289@adacore.com> <alpine.LNX.2.00.1203141707100.27160@zhemvz.fhfr.qr> <E84AEAAD-CEF2-4ECD-AECC-AFFB123B2AAC@adacore.com> <alpine.LNX.2.00.1203151036400.27160@zhemvz.fhfr.qr> <6BCCAF3B-005E-449E-917C-4B88B78F1946@adacore.com> <alpine.LNX.2.00.1203201310000.4662@zhemvz.fhfr.qr> <20FDC949-4630-403F-94E9-7F75B6E5E120@adacore.com> <alpine.LNX.2.00.1203201516150.4662@zhemvz.fhfr.qr> <D999EBA8-A0F5-49E6-9BC3-90A44A8BE9DD@adacore.com> <alpine.LNX.2.00.1203201701230.4662@zhemvz.fhfr.qr>
To: Richard Guenther <rguenther@suse.de>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-03/txt/msg01365.txt.bz2


On Mar 20, 2012, at 5:01 PM, Richard Guenther wrote:

> On Tue, 20 Mar 2012, Tristan Gingold wrote:
>=20
>>=20
>> On Mar 20, 2012, at 3:19 PM, Richard Guenther wrote:
>>=20
>> [=85]
>>>=20
>>> I'd rather get away from using a global main_identifier_node, instead
>>> make that frontend specific, and introduce targetm.main_assembler_name
>>> which the assembler-name creating langhook would make sure to use
>>> when mangling what the FE thinks main is.  main_identifier_node should
>>> not serve any purpose outside of Frontends.
>>>=20
>>> But I see both as a possible cleanup opportunity, not a necessary chang=
e.
>>=20
>> Something along these lines ?
>=20
> Yes, but I'd simply call the hook at the places you now use
> main_assembler_name and not create a global tree node for it.

But we use it at the beginning of graph_finalize_function, so caching it
makes sense, doesn't it ?

Tristan.