[POST A NEW PORT]

[POST A NEW PORT]

[Nguyễn Sinh Ngọc]

Dear all,

I have developed a new port for microcontroller 8bit.
How can I post it into gcc-patches for everyone reviewing?

I don't have the account on gcc.gnu.org which have the privileged to
post it to gcc-patches by git.
How can I register a new account?

-- 
Thanks & Best regards
Nguyễn Sinh Ngọc
Software Department
IC Design & Research Education Center
Email: ngoc.nguyensinh@icdrec.edu.vn
Cell Phone: +84 (0)974117946

Re: [POST A NEW PORT]

[Mike Stump]

On Jan 19, 2016, at 7:50 PM, Nguyễn Sinh Ngọc <ngoc.nguyensinh@icdrec.edu.vn> wrote:
> How can I post it into gcc-patches for everyone reviewing?

Just send an email with it.  If too large for a single email, you can compress it.  If still too large, you can drop it on a server and just post a link to the file.

new port: vn8

[Mike Stump]

I don’t see the point of libgcc/config/vn8/test.patch.  I suspect either you need to apply it to your diffs before you send them out, or remove the file a junk from the diff set.

I saw:

  inflating: libgcc/config/vn8/lib1funcs-fixed.S  
  inflating: libgcc/config/vn8/lib1funcs-fixed.S.old  
  inflating: libgcc/config/vn8/lib1funcs.S  
  inflating: libgcc/config/vn8/lib1funcs.S.old  

and suspect the .old files are old, and aren’t used by the build.  If so, they can be removed.

I saw:

  inflating: gcc/config/vn8/vn8.md.bak  
  inflating: gcc/config/vn8/vn8.md.bk 
  inflating: gcc/config/vn8/t-vn8.bak  

and suspect these aren’t needed (or are badly named) and should be removed.

I glanced at the non-port files, and all that code looks fine.

> I used gcc-4.9.0 version for new port.

So, you will want to check out a copy of the compiler from git or svn.  You will want to do this checkout from the trunk.  You then want to apply your patch set to it, and build and test it, fixing any issues that arise, and then contribute that.  The patch set you sent would be a back port to a release branch, if any, and would come after the port is accepted into trunk.

> //          output_addr_const (stderr, addr); 
> //          fprintf(stderr,"\n”);
> //          rtx temp_rtx = XEXP(XEXP(x,0),0);

It is now time to figure out what to do with this code.  If you like it and want to keep it, instead do:

#define PORTDEBUGGING 0

  if (PORTDEBUGGING)
    {
    }

and turn it into normal code.

> #if 0
> ADJUST_BYTESIZE (QI, 1);
> ADJUST_BYTESIZE (HI, 1);
> ADJUST_BYTESIZE (SI, 2);
> ADJUST_BYTESIZE (PSI, 3);
> ADJUST_BYTESIZE (DI, 4);
> ADJUST_BYTESIZE (TI, 8);
> #endif // 1

You should just remove the whole block.


I’d recommend fixing all the above and reposting.  Someone else will do a more in depth port review and comment further.

If you don’t have your paper work done, you will want to start up that process now.  The port can’t go into the compiler without it.



One last comment, while you wait for the review of the port code, you should consider your FIXMEs and decide if there is any progress you can make on them.

./gcc/config/vn8/vn8.c:  /* FIXME: For setjmp and in vn8_builtin_setjmp_frame_value we don't know
./gcc/config/vn8/vn8.c:  /* FIXME:  Non-generic addresses are not mode-dependent in themselves.
./gcc/config/vn8/vn8.c:      /* FIXME: We ship info on failing tail-call in struct machine_function.
./gcc/config/vn8/vn8.c:      /* FIXME: For OS_task and OS_main, this might be over-conservative.  */
./gcc/config/vn8/vn8.c:  /* FIXME: Ideally, the following test is not needed.
./gcc/config/vn8/vn8.c:  /* FIXME: This hook gets called with MODE:REGNO combinations that don't
./gcc/config/vn8/vn8.c:     FIXME: Filter out cases where the target object is known to
./gcc/config/vn8/vn8.c:  /* FIXME: Register allocator might come up with spill fails if it is left
./gcc/config/vn8/vn8.c:  /* FIXME: Register allocator does a bad job and might spill address

Re: new port: vn8

[Nguyễn Sinh Ngọc]

Hello Mike Stump,

Thanks for your comment.
I'll remove all of redundant code for this target.

I wonder that what paper is?
Is it an introduction about new feature in our target?

On Wed, Jan 27, 2016 at 5:53 AM, Mike Stump <mikestump@comcast.net> wrote:
> I don’t see the point of libgcc/config/vn8/test.patch.  I suspect either you need to apply it to your diffs before you send them out, or remove the file a junk from the diff set.
>
> I saw:
>
>   inflating: libgcc/config/vn8/lib1funcs-fixed.S
>   inflating: libgcc/config/vn8/lib1funcs-fixed.S.old
>   inflating: libgcc/config/vn8/lib1funcs.S
>   inflating: libgcc/config/vn8/lib1funcs.S.old
>
> and suspect the .old files are old, and aren’t used by the build.  If so, they can be removed.
>
> I saw:
>
>   inflating: gcc/config/vn8/vn8.md.bak
>   inflating: gcc/config/vn8/vn8.md.bk
>   inflating: gcc/config/vn8/t-vn8.bak
>
> and suspect these aren’t needed (or are badly named) and should be removed.
>
> I glanced at the non-port files, and all that code looks fine.
>
>> I used gcc-4.9.0 version for new port.
>
> So, you will want to check out a copy of the compiler from git or svn.  You will want to do this checkout from the trunk.  You then want to apply your patch set to it, and build and test it, fixing any issues that arise, and then contribute that.  The patch set you sent would be a back port to a release branch, if any, and would come after the port is accepted into trunk.
>
>> //          output_addr_const (stderr, addr);
>> //          fprintf(stderr,"\n”);
>> //          rtx temp_rtx = XEXP(XEXP(x,0),0);
>
> It is now time to figure out what to do with this code.  If you like it and want to keep it, instead do:
>
> #define PORTDEBUGGING 0
>
>   if (PORTDEBUGGING)
>     {
>     }
>
> and turn it into normal code.
>
>> #if 0
>> ADJUST_BYTESIZE (QI, 1);
>> ADJUST_BYTESIZE (HI, 1);
>> ADJUST_BYTESIZE (SI, 2);
>> ADJUST_BYTESIZE (PSI, 3);
>> ADJUST_BYTESIZE (DI, 4);
>> ADJUST_BYTESIZE (TI, 8);
>> #endif // 1
>
> You should just remove the whole block.
>
>
> I’d recommend fixing all the above and reposting.  Someone else will do a more in depth port review and comment further.
>
> If you don’t have your paper work done, you will want to start up that process now.  The port can’t go into the compiler without it.
>
>
>
> One last comment, while you wait for the review of the port code, you should consider your FIXMEs and decide if there is any progress you can make on them.
>
> ./gcc/config/vn8/vn8.c:  /* FIXME: For setjmp and in vn8_builtin_setjmp_frame_value we don't know
> ./gcc/config/vn8/vn8.c:  /* FIXME:  Non-generic addresses are not mode-dependent in themselves.
> ./gcc/config/vn8/vn8.c:      /* FIXME: We ship info on failing tail-call in struct machine_function.
> ./gcc/config/vn8/vn8.c:      /* FIXME: For OS_task and OS_main, this might be over-conservative.  */
> ./gcc/config/vn8/vn8.c:  /* FIXME: Ideally, the following test is not needed.
> ./gcc/config/vn8/vn8.c:  /* FIXME: This hook gets called with MODE:REGNO combinations that don't
> ./gcc/config/vn8/vn8.c:     FIXME: Filter out cases where the target object is known to
> ./gcc/config/vn8/vn8.c:  /* FIXME: Register allocator might come up with spill fails if it is left
> ./gcc/config/vn8/vn8.c:  /* FIXME: Register allocator does a bad job and might spill address



-- 
Thanks & Best regards
Nguyễn Sinh Ngọc
Software Department
IC Design & Research Education Center
Email: ngoc.nguyensinh@icdrec.edu.vn
Cell Phone: +84 (0)974117946

Re: new port: vn8

[Mike Stump]

On Jan 26, 2016, at 10:33 PM, Nguyễn Sinh Ngọc <ngoc.nguyensinh@icdrec.edu.vn> wrote:
> I wonder that what paper is?
> Is it an introduction about new feature in our target?

I was not able to make any sense of these two question.  Likely a language barrier.  If you can find a way to rephrase them…  I can try and answer.

Re: new port: vn8

[Nguyễn Sinh Ngọc]

> If you don’t have your paper work done, you will want to start up that process now.  The port can’t go into the compiler without it.

What is the paper?
Can you explain more about it?

On Thu, Jan 28, 2016 at 2:47 AM, Mike Stump <mikestump@comcast.net> wrote:
> On Jan 26, 2016, at 10:33 PM, Nguyễn Sinh Ngọc <ngoc.nguyensinh@icdrec.edu.vn> wrote:
>> I wonder that what paper is?
>> Is it an introduction about new feature in our target?
>
> I was not able to make any sense of these two question.  Likely a language barrier.  If you can find a way to rephrase them…  I can try and answer.



-- 
Thanks & Best regards
Nguyễn Sinh Ngọc
Software Department
IC Design & Research Education Center
Email: ngoc.nguyensinh@icdrec.edu.vn
Cell Phone: +84 (0)974117946

Re: new port: vn8

[Bernhard Reutner-Fischer]

On January 27, 2016 8:47:15 PM GMT+01:00, Mike Stump <mikestump@comcast.net> wrote:
>On Jan 26, 2016, at 10:33 PM, Nguyễn Sinh Ngọc
><ngoc.nguyensinh@icdrec.edu.vn> wrote:
>> I wonder that what paper is?
>> Is it an introduction about new feature in our target?
>
>I was not able to make any sense of these two question.  Likely a
>language barrier.  If you can find a way to rephrase them…  I can try
>and answer.

I guess gcc.gnu.org/contribute.html#legal

I.e. copyright assignment.

HTH,

Re: new port: vn8

[Mike Stump]

On Jan 27, 2016, at 7:12 PM, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
> On January 27, 2016 8:47:15 PM GMT+01:00, Mike Stump <mikestump@comcast.net> wrote:
>> On Jan 26, 2016, at 10:33 PM, Nguyễn Sinh Ngọc
>> <ngoc.nguyensinh@icdrec.edu.vn> wrote:
>>> I wonder that what paper is?
>>> Is it an introduction about new feature in our target?
>> 
>> I was not able to make any sense of these two question.  Likely a
>> language barrier.  If you can find a way to rephrase them…  I can try
>> and answer.
> 
> I guess gcc.gnu.org/contribute.html#legal
> 
> I.e. copyright assignment.

Yes.  In theory someone on this list will help you with it.  I just don’t know who usually does this; they should step forward and help get you the right assignments.  If you don’t hear some someone soon, just ping the list for help on the copyright assignment forms.

Re: new port: vn8

[Sandra Loosemore]

Where is the patch under discussion here?  I can't find it in the archives.

-Sandra

Re: new port: vn8

[Nguyễn Sinh Ngọc]

> Where is the patch under discussion here?  I can't find it in the archives.

This is the source code of VN8 target:
https://drive.google.com/file/d/0B169XTHeyQCfb2ZVak5VRm4tcHc/view?usp=sharing



-- 
Thanks & Best regards
Nguyễn Sinh Ngọc
Software Department
IC Design & Research Education Center
Email: ngoc.nguyensinh@icdrec.edu.vn
Cell Phone: +84 (0)974117946

Re: new port: vn8

[Mike Stump]

On Jan 27, 2016, at 7:36 PM, Sandra Loosemore <sandra@codesourcery.com> wrote:
> Where is the patch under discussion here?  I can't find it in the archives.

It was 500+K after compression.  The port didn’t seem terribly large to me.

Re: new port: vn8

[Sandra Loosemore]

On 01/27/2016 08:47 PM, Nguyễn Sinh Ngọc wrote:
>> Where is the patch under discussion here?  I can't find it in the archives.
>
> This is the source code of VN8 target:
> https://drive.google.com/file/d/0B169XTHeyQCfb2ZVak5VRm4tcHc/view?usp=sharing

Thanks.  I skimmed it over quickly to see if the documentation changes 
were in order, but I can't find any.  :-(  When you revise the port 
against current trunk and resubmit it for review, please remember to add 
documentation for all the target-specific command-line options and 
built-in functions in the appropriate sections of the GCC manual.

-Sandra

Re: new port: vn8

[Joseph Myers]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

On Wed, 27 Jan 2016, Sandra Loosemore wrote:

> On 01/27/2016 08:47 PM, Nguyễn Sinh Ngọc wrote:
> > > Where is the patch under discussion here?  I can't find it in the
> > > archives.
> > 
> > This is the source code of VN8 target:
> > https://drive.google.com/file/d/0B169XTHeyQCfb2ZVak5VRm4tcHc/view?usp=sharing
> 
> Thanks.  I skimmed it over quickly to see if the documentation changes were in
> order, but I can't find any.  :-(  When you revise the port against current
> trunk and resubmit it for review, please remember to add documentation for all
> the target-specific command-line options and built-in functions in the
> appropriate sections of the GCC manual.

Specifically, follow the checklist in sourcebuild.texi for everything that 
needs to be documented for a new port.  And if it's too big for 
gcc-patches, split it into as many messages as necessary for it to be 
accepted by the list, don't provide it only as a link to an external site.

-- 
Joseph S. Myers
joseph@codesourcery.com