From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37328 invoked by alias); 12 Dec 2018 15:36:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37276 invoked by uid 89); 12 Dec 2018 15:36:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=advance!, Hx-languages-length:835, H*r:140, H*c:HHHHHHHH X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Dec 2018 15:35:59 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 0205181353; Wed, 12 Dec 2018 16:35:56 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MDTk8Yw8tg8V; Wed, 12 Dec 2018 16:35:55 +0100 (CET) Received: from [IPv6:2a02:2ab8:224:1:140:a4cc:e897:ea19] (unknown [IPv6:2a02:2ab8:224:1:140:a4cc:e897:ea19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id DBCD781348; Wed, 12 Dec 2018 16:35:55 +0100 (CET) From: Olivier Hainque Message-Id: <1E507F62-7BE3-4469-82E6-F24B2E4CF090@adacore.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_9CF64A2C-6026-4CE4-B9DF-687236992AD5" Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: [ping] use REGNUM macros instead of hardcoded values in aarch64 PROBE_STACK reg definitions Date: Wed, 12 Dec 2018 15:36:00 -0000 In-Reply-To: <42AD5419-370A-45B0-92EF-83F84CFD7EB9@adacore.com> Cc: Olivier Hainque , Kyrylo Tkachov , Wilco Dijkstra To: GCC Patches References: <42AD5419-370A-45B0-92EF-83F84CFD7EB9@adacore.com> X-SW-Source: 2018-12/txt/msg00826.txt.bz2 --Apple-Mail=_9CF64A2C-6026-4CE4-B9DF-687236992AD5 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Content-length: 749 Hello, Ping for one of the changes last proposed here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00761.html Submitted separately as an attempt to facilitate the review process. Got access to a linux box, so in addition to the Ada testing we do on cross aarch64-vxworks7, bootstrapped and regression tested on aarch64-linux. This one is just a simple use of REGNUM macros instead of harcoded values in the definition of PROBE_STACK_FIRST_REG and PROBE_STACK_SECOND_REG in aarch64.c. OK to commit ? Thanks in advance! Olivier 2018-12-12 Olivier Hainque * config/aarch64/aarch64.c (PROBE_STACK_FIRST_REG) : Redefine as R9_REGNUM instead of 9. (PROBE_STACK_SECOND_REG): Redefine as R10_REGNUM instead of 10. --Apple-Mail=_9CF64A2C-6026-4CE4-B9DF-687236992AD5 Content-Disposition: attachment; filename=0001-Use-REGNUM-macros-in-the-definitions-of-aarch64-PROB.patch Content-Type: application/octet-stream; x-unix-mode=0640; name="0001-Use-REGNUM-macros-in-the-definitions-of-aarch64-PROB.patch" Content-Transfer-Encoding: quoted-printable Content-length: 1246 >From 02518d7099c8376c7de67c90a59735199aa660bf Mon Sep 17 00:00:00 2001=0A= From: Olivier Hainque =0A= Date: Wed, 12 Dec 2018 06:49:59 -0800=0A= Subject: [PATCH 1/4] Use REGNUM macros in the definitions of aarch64=0A= PROBE_STACK regs=0A= =0A= * config/aarch64/aarch64.c (PROBE_STACK_FIRST_REG) : Redefine as=0A= R9_REGNUM instead of 9.=0A= (PROBE_STACK_SECOND_REG): Redefine as R10_REGNUM instead of 10.=0A= ---=0A= gcc/config/aarch64/aarch64.c | 4 ++--=0A= 1 file changed, 2 insertions(+), 2 deletions(-)=0A= =0A= diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c=0A= index 3d597ca..891de75 100644=0A= --- a/gcc/config/aarch64/aarch64.c=0A= +++ b/gcc/config/aarch64/aarch64.c=0A= @@ -3896,8 +3896,8 @@ aarch64_libgcc_cmp_return_mode (void)=0A= #endif=0A= =20=0A= /* The pair of scratch registers used for stack probing. */=0A= -#define PROBE_STACK_FIRST_REG 9=0A= -#define PROBE_STACK_SECOND_REG 10=0A= +#define PROBE_STACK_FIRST_REG R9_REGNUM=0A= +#define PROBE_STACK_SECOND_REG R10_REGNUM=0A= =20=0A= /* Emit code to probe a range of stack addresses from FIRST to FIRST+POLY_= SIZE,=0A= inclusive. These are offsets from the current stack pointer. */=0A= --=20=0A= 1.9.1=0A= =0A= --Apple-Mail=_9CF64A2C-6026-4CE4-B9DF-687236992AD5--