From: Xi Ruoyao <xry111@xry111.site>
To: chenglulu <chenglulu@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: Ping: [PATCH] LoongArch: Replace -mexplicit-relocs=auto simple-used address peephole2 with combine
Date: Sun, 24 Dec 2023 20:59:29 +0800 [thread overview]
Message-ID: <1a13ff935218c67f72bc83175960e819677e317a.camel@xry111.site> (raw)
In-Reply-To: <e7b4e202f115a101ad8e26ab40a072d14ea265af.camel@xry111.site>
On Sat, 2023-12-23 at 18:47 +0800, Xi Ruoyao wrote:
> On Sat, 2023-12-23 at 18:44 +0800, Xi Ruoyao wrote:
> > On Sat, 2023-12-23 at 10:29 +0800, chenglulu wrote:
> > > > The performance drop has nothing to do with this patch. I found that the h264 performance compiled
> > > > by r14-6787 compared to r14-6421 dropped by 6.4%.
> >
> > Then I guess we should create a bug report...
> >
> > > But there is a problem. My regression test has the following two fail items.(based on r14-6787)
> >
> > > +FAIL: gcc.dg/cpp/_Pragma3.c (test for excess errors)
>
> I guess this is https://gcc.gnu.org/PR28123.
>
> > > +FAIL: gcc.dg/pr86617.c scan-rtl-dump-times final "mem/v" 6
>
> I'll take a look on this. Maybe it will show up with Binutils trunk (I
> just realized I tested this patch with Binutils 2.41, and it's not
> sufficient to really test the change).
I cannot reproduce the issue on a Gentoo dev machine with Binutils
2.41.50.20231218 and the patch on top of r14-6819. And in my manual
testing (for ruling out the difference caused by default PIE and SSP)
the test also passes:
xry111@nanmen2 ~/git-repos/gcc-build $ /home/xry111/git-repos/gcc-
build/gcc/xgcc -B/home/xry111/git-repos/gcc-build/gcc/ /home/xry111/git-
repos/gcc/gcc/testsuite/gcc.dg/pr86617.c -fdiagnostics-plain-output -Os
-fdump-rtl-final -ffat-lto-objects -S -o pr86617.s -fno-stack-protector
-fno-pie && grep -c mem/v pr86617.c.348r.final
6
Could you recheck with latest GCC master?
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-12-24 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 6:47 Xi Ruoyao
2023-12-21 11:56 ` Ping: " Xi Ruoyao
2023-12-21 12:00 ` chenglulu
2023-12-22 3:44 ` chenglulu
2023-12-22 7:09 ` Xi Ruoyao
2023-12-22 7:21 ` chenglulu
2023-12-23 2:26 ` chenglulu
2023-12-23 2:29 ` chenglulu
2023-12-23 10:44 ` Xi Ruoyao
2023-12-23 10:47 ` Xi Ruoyao
2023-12-24 12:59 ` Xi Ruoyao [this message]
2023-12-25 2:08 ` chenglulu
2023-12-25 10:38 ` Xi Ruoyao
2023-12-27 3:59 ` chenglulu
2023-12-27 11:21 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a13ff935218c67f72bc83175960e819677e317a.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).