From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 5DD6A3858422 for ; Mon, 27 Mar 2023 12:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DD6A3858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,294,1673942400"; d="scan'208";a="588617" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 27 Mar 2023 04:01:16 -0800 IronPort-SDR: An0CLrh3qMWDqxpO64t21YjSgmL1ThSzPSbjnN/7zMgI6q2HB2AUevw1/e7O8on6kKAl9Y3+Rw NPHxpRpsEnYmXvAvN1ZOMVhY5d9Wwmpn9hbH88Xzdpswy+uxNLO5UQ9zdzAJCDE6rYKpw/HUkg Xm0MGxrpwjo4LkfqDL7Js1EPOK14nodjIYHSwiM0ffSZjGr24bYFcbc9pAHNFdcvxjNvsy4T3k KrMidROzhJNyizJOGd9sJ/FDgUZONc342OmQ6+rkBh+RTPkLpsHJSgy3h7q0bPKixixsn7tYV8 +sM= Message-ID: <1a37516b-7584-1c45-8f6f-17a121bbcfc2@codesourcery.com> Date: Mon, 27 Mar 2023 13:01:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] libgomp, openmp: pinned memory) Content-Language: en-GB To: Thomas Schwinge , , Tobias Burnus References: <87bkki9mji.fsf@euler.schwinge.homeip.net> <878rfiqvtn.fsf@euler.schwinge.homeip.net> From: Andrew Stubbs In-Reply-To: <878rfiqvtn.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/03/2023 12:26, Thomas Schwinge wrote: > Hi! > > On 2023-03-27T09:27:31+0000, "Stubbs, Andrew" wrote: >>> -----Original Message----- >>> From: Thomas Schwinge >>> Sent: 24 March 2023 15:50 >>> >>> On 2022-01-04T15:32:17+0000, Andrew Stubbs >>> wrote: >>>> This patch implements the OpenMP pinned memory trait [...] >>> >>> I figure it may be helpful to document the current og12 state of affairs; does >>> the attached "libgomp: Document OpenMP 'pinned' memory" look good to >>> you? >> >> I don't really know what "allocated via the device" means? > > Heh, you're right. > >> I mean, I presume you mean "via CUDA", but I don't think this is obvious to the average reader. >> Maybe "allocation is optimized for the device" or some such thing? > > As we're in sections that are documenting GCN vs. nvptx specifics, we > might indeed call out which exact interfaces we're using. > > How's the updated "libgomp: Document OpenMP 'pinned' memory", see > attached? LGTM, FWIW. Andrew