public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: debug container mutex association
Date: Tue, 27 Sep 2016 21:14:00 -0000	[thread overview]
Message-ID: <1a3c5bfe-8b45-e251-9901-753980530fbe@gmail.com> (raw)
In-Reply-To: <20160927152915.GA12862@redhat.com>

On 27/09/2016 17:29, Jonathan Wakely wrote:
> On 20/09/16 09:53 +0100, Jonathan Wakely wrote:
>> On 19/09/16 21:56 +0200, François Dumont wrote:
>>> Hi
>>>
>>>   Following our conversation here is a much simpler patch. I just 
>>> consider that all debug containers will have the same alignment.
>>>
>>>   Even if I submit this patch as a whole I will commit into pieces, 
>>> at least one for the pure cleanup parts and one for the debug.cc 
>>> change.
>>>
>>>   Among those changes there is:
>>> -       __gnu_cxx::__scoped_lock(this->_M_get_mutex());
>>> +       __gnu_cxx::__scoped_lock __l(this->_M_get_mutex());
>>>
>>>   I would appreciate if you could tell me what was happening with 
>>> the initial expression. I don't understand why it is compiling. I 
>>> even tried the same in debug.cc and started having compilation errors.
>>
>> It creates a temporary __scoped_lock, which immediately goes out of
>> scope and unlocks the mutex again. This should be fixed on the gcc-5
>> and gcc-6 branches too.
>
> I'm committing this to the gcc-5 and gcc-6 branches.
>
>
I still had plan to do so but if you have those branches under your 
hands I appreciate.

Thanks,

François

  reply	other threads:[~2016-09-27 20:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 20:37 François Dumont
2016-09-14  9:01 ` Jonathan Wakely
2016-09-14 20:53   ` François Dumont
2016-09-15  9:15     ` Jonathan Wakely
2016-09-19 20:19       ` François Dumont
2016-09-20  8:58         ` Jonathan Wakely
2016-09-27 15:39           ` Jonathan Wakely
2016-09-27 21:14             ` François Dumont [this message]
2016-09-20  9:20         ` Jonathan Wakely
2016-09-26 11:55           ` Jonathan Wakely
2016-09-26 12:23         ` Andreas Schwab
2016-09-26 22:09           ` François Dumont
2016-09-27 10:32             ` Jonathan Wakely
2016-09-28 19:35               ` François Dumont
2016-09-28 19:47                 ` Jonathan Wakely
2017-12-29 16:10         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a3c5bfe-8b45-e251-9901-753980530fbe@gmail.com \
    --to=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).