From: Jeff Law <law@redhat.com>
To: Sandra Loosemore <sandra@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, testsuite] Add -fdelete-null-pointer-checks to some C++ testcases
Date: Thu, 23 Jan 2020 20:54:00 -0000 [thread overview]
Message-ID: <1a43c73911e10637b2e33b07d1abfc085821c37e.camel@redhat.com> (raw)
In-Reply-To: <f15851e2-5c46-e9da-e510-c3e0714b0c68@codesourcery.com>
On Tue, 2020-01-21 at 15:00 -0700, Sandra Loosemore wrote:
> In doing some nios2-elf testing, I ran into a bunch of failures in
> constexpr-related tests in the C++ testsuite. This target defaults to
> -fno-delete-null-pointer-checks at the request of Altera/Intel, in order
> to support some of their BSPs where 0 is a legitimate memory address.
> Some other bare-metal targets also default to
> -fno-delete-null-pointer-checks.
>
> This patch makes the dependence of these tests on
> -fdelete-null-pointer-checks explicit. I've previously fixed some other
> tests that failed on nios2-elf in the same way so this is borderline
> obvious, but it's a little troubling to me that the correct semantics of
> some of these testcases seems to depend on what we document in the
> manual as an optimization option. :-S Maybe there is some other bug here?
>
> Anyway, if nobody has any objections or better ideas, I will go ahead
> and commit this in a few days.
It'd be nice to know why that flag matters for constexpr. But I've got
no problem with the change itself.
jeff
next prev parent reply other threads:[~2020-01-23 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 23:22 Sandra Loosemore
2020-01-23 20:54 ` Jeff Law [this message]
2020-01-23 22:17 ` Sandra Loosemore
2020-01-24 0:22 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a43c73911e10637b2e33b07d1abfc085821c37e.camel@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).