Re: [PATCH] gcc: honour -ffile-prefix-map in ASM_MAP [PR93371]

[Jeff Law <jeffreyalaw@gmail.com>]

On 11/3/22 07:29, Rasmus Villemoes wrote:
> On 02/11/2022 16.45, Jeff Law wrote:
>> On 11/2/22 06:35, Rasmus Villemoes wrote:
>>> However, when I try to push the new master branch I get
>>>
>>> $ git push origin master
>>> fatal: remote error: service not enabled: /git/gcc.git
>>>
>>> I do gcc patches sufficiently rare that I may have forgotten the right
>>> procedure, but this is what I think I've done previously (along with
>>> running a "git gcc-verify HEAD" to ensure there's a proper changelog
>>> fragment to extract, with gcc-verify being a suitable alias).
>>>
>>> Have I simply lost by commit bit?
>> No idea what that error means.  If I had to guess, it'd be that you've
>> got an anonymous checkout tree which is obviously unsuitable for pushing
>> or something of that nature.
>>
>> It's probably just faster/easier for me to push it for you.  I'll take
>> care of it momentarily.
> Thanks.
>
> I think I found out what was wrong (though I know it has worked for me
> previously): My remote url was git://gcc.gnu.org/git/gcc.git , and I
> used to rely on my .ssh/config specifying "villemoes" as username when
> accessing gcc.gnu.org. For some reason that no longer worked, but
> updating the remote url to git+ssh://villemoes@gcc.gnu.org/git/gcc.git
> seemed to do the trick.

Good to know you got it sorted out.


>
> What do you think about applying this to older branches? IMO it's a
> defect from when the umbrella -ffile-prefix-map was introduced, and the
> potential for regressions should be very low, but I can also see how it
> might not really qualify as a bug fix.

I'd probably lean against backporting.  Generally we try to limit 
backporting to regression fixes, incorrect code generation issues and 
the like.  This seems much less serious.


Jeff