From: Jiahao Xu <xujiahao@loongson.cn>
To: chenglulu <chenglulu@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: xry111@xry111.site, i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH] Loongarch: Remove vec_concatz<mode> pattern
Date: Thu, 25 Jan 2024 15:50:16 +0800 [thread overview]
Message-ID: <1b658daa-9f5f-6ad9-e184-1442f2a29106@loongson.cn> (raw)
In-Reply-To: <a3979c88-842f-cccc-664b-7f348b090682@loongson.cn>
在 2024/1/25 下午3:46, chenglulu 写道:
> Jiahao:
>
> Note that the LoongArch 'a' in the title needs to be capitalized.
>
> I modified this patch and incorporated it first.
>
>
Thanks, I'll pay attention next time.
> 在 2024/1/24 下午5:19, Jiahao Xu 写道:
>> It is incorrect to use vld/vori to implement the vec_concatz<mode>
>> because when the LSX
>> instruction is used to update the value of the vector register, the
>> upper 128 bits of
>> the vector register will not be zeroed.
>>
>> gcc/ChangeLog:
>>
>> * config/loongarch/lasx.md (@vec_concatz<mode>): Remove this
>> define_insn pattern.
>> * config/loongarch/loongarch.cc
>> (loongarch_expand_vector_group_init): Use vec_concat<mode>.
>>
>> diff --git a/gcc/config/loongarch/lasx.md b/gcc/config/loongarch/lasx.md
>> index 90f66ee4d24..e2115ffb884 100644
>> --- a/gcc/config/loongarch/lasx.md
>> +++ b/gcc/config/loongarch/lasx.md
>> @@ -582,21 +582,6 @@ (define_insn "lasx_xvinsgr2vr_<lasxfmt_f_wd>"
>> [(set_attr "type" "simd_insert")
>> (set_attr "mode" "<MODE>")])
>> -(define_insn "@vec_concatz<mode>"
>> - [(set (match_operand:LASX 0 "register_operand" "=f")
>> - (vec_concat:LASX
>> - (match_operand:<VHMODE256_ALL> 1 "nonimmediate_operand")
>> - (match_operand:<VHMODE256_ALL> 2 "const_0_operand")))]
>> - "ISA_HAS_LASX"
>> -{
>> - if (MEM_P (operands[1]))
>> - return "vld\t%w0,%1";
>> - else
>> - return "vori.b\t%w0,%w1,0";
>> -}
>> - [(set_attr "type" "simd_splat")
>> - (set_attr "mode" "<MODE>")])
>> -
>> (define_insn "vec_concat<mode>"
>> [(set (match_operand:LASX 0 "register_operand" "=f")
>> (vec_concat:LASX
>> diff --git a/gcc/config/loongarch/loongarch.cc
>> b/gcc/config/loongarch/loongarch.cc
>> index 072c68d97e3..cd335827570 100644
>> --- a/gcc/config/loongarch/loongarch.cc
>> +++ b/gcc/config/loongarch/loongarch.cc
>> @@ -9917,17 +9917,12 @@ loongarch_expand_vector_group_init (rtx
>> target, rtx vals)
>> gcc_unreachable ();
>> }
>> - if (high == CONST0_RTX (half_mode))
>> - emit_insn (gen_vec_concatz (vmode, target, low, high));
>> - else
>> - {
>> - if (!register_operand (low, half_mode))
>> - low = force_reg (half_mode, low);
>> - if (!register_operand (high, half_mode))
>> - high = force_reg (half_mode, high);
>> - emit_insn (gen_rtx_SET (target,
>> - gen_rtx_VEC_CONCAT (vmode, low, high)));
>> - }
>> + if (!register_operand (low, half_mode))
>> + low = force_reg (half_mode, low);
>> + if (!register_operand (high, half_mode))
>> + high = force_reg (half_mode, high);
>> + emit_insn (gen_rtx_SET (target,
>> + gen_rtx_VEC_CONCAT (vmode, low, high)));
>> }
>> /* Expand initialization of a vector which has all same
>> elements. */
next prev parent reply other threads:[~2024-01-25 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 9:19 Jiahao Xu
2024-01-25 7:46 ` chenglulu
2024-01-25 7:50 ` Jiahao Xu [this message]
2024-01-25 7:55 ` [pushed][PATCH] " chenglulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b658daa-9f5f-6ad9-e184-1442f2a29106@loongson.cn \
--to=xujiahao@loongson.cn \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).