From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 286C03858D20 for ; Fri, 7 Jun 2024 23:04:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 286C03858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 286C03858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717801469; cv=none; b=uFbY9IJOuz68R6gns1wGaHsIwLVg/0WewT3CAbFEdAWsGUVwWB+MmyVkh/wLmpnyWLCvXmRaRyJrTkWr2shNwNaQoYaAnQCs/2m5jkp7tQOeFOxbsNSdxo2v2Pqp+LAiNMDS9tDc88gCUQOPE8oUl3lZE0zfFYlWy/O3/cpvg/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717801469; c=relaxed/simple; bh=AR9RfjXjDLi4IhpUP58eZnWhg9uQGeiIJt+Yc8jMgVg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KXk7LeGQzndH3w0A03h9FTf+kN9wXHHjXA7l4cVqw4f5UEgydfg/1CbJgn0NerAEF8L/q4CFO4pG1FDY2TIynREBD03JKTHJgivUQrsjQrEBYpYq80eT1iN5O9bgfC/3FN3bDewHbhKUOnNpuIf0DfaoRDqSiWofHCbsmQ/xOFo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-42122ac2f38so15589195e9.1 for ; Fri, 07 Jun 2024 16:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717801465; x=1718406265; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Evkern07ByRMrT3zRD2mikA3ohrWgSEwXQm73ZtNtR4=; b=S6g5hIKX3fRZDy2dXowbpoowkoVY6uiX6ssRDp00BdXTa7vhFrWDMPs10KfrtFhPuP r/KwgDKlzLfCK9jBbf31RjqQ9jbXTlDDLlyvIpSSvLSgRhYVsoF0GWChDu2P1l85ZcQO K5a/l/aHMxkK11B4ELVWeZr3yQqcpN3/Do31ozxz5lkTyesvTVWuEyDMEYbSVi4gdjXr +0VZMnWYIJ8iN1Ytyd6yw1VGCz22EMV5u3YD5bP62Inh13hSMI/8AppumuCzHZRxtXB7 ovD22AmlbUb2eImVd0p4mqi5bcBOeDaBY1hbXmLFXYx7WDLIXWs6UZwFCdAh1Xp8EU+y ndNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717801465; x=1718406265; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Evkern07ByRMrT3zRD2mikA3ohrWgSEwXQm73ZtNtR4=; b=OvmVf8R5x7qqT+9FcYVE1ecbNKsMbETi+bit/T9I6HEYmpFbBhALQMe3WO2y2chOmR u91l/6j4gsYVVDQ16r1XA/oCBMvCcbXl/qev1isRohuvk9iKIbWXFjUA4MvKNMHb49dO HRRwoDz9JBZkCTHlOkqpAlZvRTAqo+VebsTaoucrT+qhfBTo4TqylpTs6d+kEebnY20l 3xduxEx4cr+L+/7upaEcWh/HX5D5REY7DFzX+DSYWuxKhSlxHaVAIbqz7rWGkKPIFhQ0 gMiOlZn/VuHklMjSboD2inSuLmcfnPfR0/7yymio+FOs7oFTAKRR0Yd0Ke2BkMo1JCv5 icaQ== X-Forwarded-Encrypted: i=1; AJvYcCXIjFO4LZlYSu/nISabKWLYPaFg4TuVYt5Sk6/yeO26Fjpaw2JilOq65wMXcHTgIouOUxl/9DD3y8y4CVqXu4f7OjNaYGkSrw== X-Gm-Message-State: AOJu0YymaknynAtMVnxsjRNydQ44F98t5jvbBnvIbjFfUFefbnx22rgn JAecT2LnqAjlxn72IiqdVk/VwaLbwWTJt+Ow0qIrlPTFAUncRe0TWbF45Xds X-Google-Smtp-Source: AGHT+IF9S2hlAIlz4oeE1Rf/Pamlsw6BAWsOscpq7pXGxvYn/oufC2XqYvawD1Z8d1L8sYeLxPSLOA== X-Received: by 2002:a05:600c:4f07:b0:421:661d:89d6 with SMTP id 5b1f17b1804b1-421661d8dacmr30416005e9.14.1717801464649; Fri, 07 Jun 2024 16:04:24 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5d4a5fdsm4837634f8f.33.2024.06.07.16.04.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 16:04:24 -0700 (PDT) Message-ID: <1b8c5ee3-3f1b-4925-b421-4bb7033a6151@gmail.com> Date: Fri, 7 Jun 2024 17:04:19 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2 2/3] RISC-V: Add Zalrsc and Zaamo testsuite support Content-Language: en-US To: Patrick O'Neill , gcc-patches@gcc.gnu.org Cc: palmer@dabbelt.com, gnu-toolchain@rivosinc.com References: <20240603215329.2664893-1-patrick@rivosinc.com> <20240603215329.2664893-3-patrick@rivosinc.com> From: Jeff Law In-Reply-To: <20240603215329.2664893-3-patrick@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/3/24 3:53 PM, Patrick O'Neill wrote: > Convert testsuite infrastructure to use Zalrsc and Zaamo rather than A. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/amo-table-a-6-amo-add-1.c: Use Zaamo rather than A. > * gcc.target/riscv/amo-table-a-6-amo-add-2.c: Ditto. > * gcc.target/riscv/amo-table-a-6-amo-add-3.c: Ditto. > * gcc.target/riscv/amo-table-a-6-amo-add-4.c: Ditto. > * gcc.target/riscv/amo-table-a-6-amo-add-5.c: Ditto. > * gcc.target/riscv/amo-table-a-6-compare-exchange-1.c: Use Zalrsc rather > than A. > * gcc.target/riscv/amo-table-a-6-compare-exchange-2.c: Ditto. > * gcc.target/riscv/amo-table-a-6-compare-exchange-3.c: Ditto. > * gcc.target/riscv/amo-table-a-6-compare-exchange-4.c: Ditto. > * gcc.target/riscv/amo-table-a-6-compare-exchange-5.c: Ditto. > * gcc.target/riscv/amo-table-a-6-compare-exchange-6.c: Ditto. > * gcc.target/riscv/amo-table-a-6-compare-exchange-7.c: Ditto. > * gcc.target/riscv/amo-table-a-6-subword-amo-add-1.c: Use Zaamo rather > than A. > * gcc.target/riscv/amo-table-a-6-subword-amo-add-2.c: Ditto. > * gcc.target/riscv/amo-table-a-6-subword-amo-add-3.c: Ditto. > * gcc.target/riscv/amo-table-a-6-subword-amo-add-4.c: Ditto. > * gcc.target/riscv/amo-table-a-6-subword-amo-add-5.c: Ditto. > * gcc.target/riscv/amo-table-ztso-amo-add-1.c: Add Zaamo option. > * gcc.target/riscv/amo-table-ztso-amo-add-2.c: Ditto. > * gcc.target/riscv/amo-table-ztso-amo-add-3.c: Ditto. > * gcc.target/riscv/amo-table-ztso-amo-add-4.c: Ditto. > * gcc.target/riscv/amo-table-ztso-amo-add-5.c: Ditto. > * gcc.target/riscv/amo-table-ztso-compare-exchange-1.c: Use Zalrsc rather > than A. > * gcc.target/riscv/amo-table-ztso-compare-exchange-2.c: Ditto. > * gcc.target/riscv/amo-table-ztso-compare-exchange-3.c: Ditto. > * gcc.target/riscv/amo-table-ztso-compare-exchange-4.c: Ditto. > * gcc.target/riscv/amo-table-ztso-compare-exchange-5.c: Ditto. > * gcc.target/riscv/amo-table-ztso-compare-exchange-6.c: Ditto. > * gcc.target/riscv/amo-table-ztso-compare-exchange-7.c: Ditto. > * gcc.target/riscv/amo-table-ztso-subword-amo-add-1.c: Ditto. > * gcc.target/riscv/amo-table-ztso-subword-amo-add-2.c: Ditto. > * gcc.target/riscv/amo-table-ztso-subword-amo-add-3.c: Ditto. > * gcc.target/riscv/amo-table-ztso-subword-amo-add-4.c: Ditto. > * gcc.target/riscv/amo-table-ztso-subword-amo-add-5.c: Ditto. > * lib/target-supports.exp: Add testsuite infrastructure support for > Zaamo and Zalrsc. So there's a lot of whitespace changes going on in target-supports.exp that make it harder to find the real changes. There's always a bit of a judgement call for that kind of thing. This one probably goes past would generally recommend, meaning that the formatting stuff would be a separate patch. A reasonable starting point would be if you're not changing the function in question, then fixing formatting in it probably should be a distinct patch. You probably should update the docs in sourcebuild.texi for the new target-supports tests. So OK for the trunk (including the whitespace fixes) with a suitable change to sourcebuild.texi. jeff