Re: [PATCH] Turn on LRA on all targets

[Jeff Law <jeffreyalaw@gmail.com>]

On 4/29/23 07:37, Roger Sayle wrote:
> 
> Segher Boessenkool wrote:
>> I send this patch now so that people can start testing.
>>
>> diff --git a/gcc/config/nvptx/nvptx.cc b/gcc/config/nvptx/nvptx.cc
>> index 89349dae9e62..e32f17377525 100644
>> --- a/gcc/config/nvptx/nvptx.cc
>> +++ b/gcc/config/nvptx/nvptx.cc
>> @@ -7601,9 +7601,6 @@ nvptx_asm_output_def_from_decls (FILE *stream, tree
> name, tree value)
>> #undef TARGET_ATTRIBUTE_TABLE
>> #define TARGET_ATTRIBUTE_TABLE nvptx_attribute_table
>>
>> -#undef TARGET_LRA_P
>> -#define TARGET_LRA_P hook_bool_void_false
>> -
>> #undef TARGET_LEGITIMATE_ADDRESS_P
>> #define TARGET_LEGITIMATE_ADDRESS_P nvptx_legitimate_address_p
> 
> 
> I've tested Segher's patch on nvptx-none with make and make -k check and
> can confirm there are no new regressions.  Nvptx is unique in that it
> doesn't
> use register allocation, i.e. GCC's only TARGET_NO_REGISTER_ALLOCATION
> target,
> so it's a little odd that it specifies which register allocator it doesn't
> use.
> 
> I hope this helps,
It does.  Consider a patch which flips the nvptx port to LRA as 
pre-approved.

I tried the FRV just for fun.  It faulted all over the place :(

jeff