From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 34C603858D35; Tue, 2 Nov 2021 14:23:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 34C603858D35 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.99.12] ([212.126.164.126]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MiacH-1mEeLl0j3f-00flO8; Tue, 02 Nov 2021 15:22:58 +0100 Subject: Re: [PATCH] PR fortran/91497 -- Silence conversion warnings for MIN1 and MAX1 To: Thomas Koenig , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <4b1a3fd9-b000-c535-4c8e-ac69aefe06be@netcologne.de> From: Manfred Schwarb Message-ID: <1c0e64df-c58b-6fe8-524a-737a4e4b88ba@gmx.ch> Date: Tue, 2 Nov 2021 15:22:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <4b1a3fd9-b000-c535-4c8e-ac69aefe06be@netcologne.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:5iXVBTL9SDlvRrIT2Q+9+53x+GCtaSr+lP8AjSEea9uqAcGEW9c Q59/KzN9km6wuaQlSJ2uwM0ZEdt/J7V27A3GG2iNuWICXHjy8J4gFhm+OUAEQZyZx/tsed1 PPA9I1MYtjx+fZNlmIH7z+4mxdWnHQMBhWmISkdwhzUc0M7QFG+bh0SgyCC54I1PnnizfXW eh8Fcu35G1G+C5sCdMxXg== X-UI-Out-Filterresults: notjunk:1;V03:K0:87pzPLq7en8=:/qrlD1TlrkW73n7SV4o3dT LMV+2IohgdeJ9laoKuSzNF9CqeixSNA4bzh019DRvjko0Y0Og6TQWSHytylBuyxRJdbwzfpim 7omlDxTSJHEo1fHLNOT/1UrOqn9nY8M1I2Mkqp43UdxiG8kQWvuhlnonT5ErcSNl2OGHLdry6 0VbF1Wvaid7bK7MpA+Conxm32Lc6QSUZM4/C3ADxLQTWrf3GdMGgbONNqhLg9TPtUZkNz6czi UKCD+SXw1nWIvu78zwxYobslotInwxQusKYxvy3CJwW0nFTKEVYUTrRC8ejvC/yf3WjtzXQo0 JuupLG728ngTUo7gWkT2ausH6gfhX2vOVxkPWs0a2dAaKKQrdS8LGEkN8vj0lafEiSqsVXg8u kMAa8+qgtCnXIsDGLJTL51BpJ24gamAy2O8JZH58iCbEM8RCkInPigHucEVTVWXmRyhPJC5pb o6QmQrxbanDngmfJq1nrQSVguHAUWQzCiZtfstR6T7BoJtmz6hBz5P7Xl3lgzeV6TRGfOH1On YzWci5AXfJIw1V8H6+K6IERfemHtylo9n8Ndsx+ryRSnWXpGK0cEzV3oaycv9PIBHsJ55zX3K rAVHTVmIaA+B6LEWLIYcmKiJOhUHX5vyyBA3WbE2VKmiyivOUGV751M9lDbwfn6c8OmZvRmsR oL0lehh4Vhh5W59i79oh5tLkEPR+uDGoYq7Vcg6xdA8TW0V77dec/V3ip0vlWkK+7U7flaPeA k7iUAi9VJnegrTiMGj5Y20s/1VAD2TE82YWQ5EHiOYoaO3+cduQW6mI3szv1BYGv7WP/GbEFy yWDSuclb4t9GvQTOHXJFNHD+IaCpGb67/yMIccCDLS8ucQE80KH3g+DXMic7SXqW+NhsqLEDs wlJWKVJu6i3zaoSQHoQAieSacmDPQKyRYJtM5xkbh9M1K2vCdp16LerzDCHXPUJlqqQJdLgQ/ D1jQTe8+PXG2g/90VawBCy0Z8UPVBed60zADwwaQguU63CsvW4JE8NSXlazWCISy75YgK7E73 7hTklnQM9hHcF+8d9vk+Xn+XvLu9wJPyH+CpMPx07LUq+CAizqOD5zUFcDIwVbYw/m5WSZ3Q/ FHhLzqSdC5Zsog= X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Nov 2021 14:23:03 -0000 Am 02.11.21 um 14:26 schrieb Thomas Koenig: > Hi Manfred, > >> In addition to the patches of Steve Kargl for PR 91497: >> The MIN1 and MAX1 intrinsics do explicit type conversions and should >> be silenced too for -Wconversion and -Wconversion-extra. >> >> Adjust testcase to only use *4 and *8 real types, provide a second >> testcase for *10 and *16 precisions. > Two points: > > We should modify existing test cases only when necessary, because > modification can impede a regression test.=C2=A0 It is better to create > a new one. > Yes, but this was a quick-and-dirty test of mine, and I realized only afte= rwards that Steve had used it as-is. The new testcase is more consistent and more= complete. Sandra got errors on targets without REAL(16) support and requested change= s, so I decided to split it. So you want me to "split" it in 3 parts? - existing test as is, only for targets with REAL(16) support - additional tests incl. complex intrinsics for targets with REAL(16) supp= ort - additional tests incl. complex intrinsics for all targets, only single a= nd double precision OTOH, it is perhaps not worth the trouble to do REAL(10) and REAL(16) test= s, either it warns or it does not. > While we do recognize real*4 and real*8 and so on, these are > non-standard extensions, and I would like to avoid to have these > with new test cases. > > Instead of real*8, you can use real(8) or double precision. > Well, double precision is deprecated AFAIK. > OK with these changes to the test cases. > > Thanks for the patch! > > Best regards > > =C2=A0=C2=A0=C2=A0=C2=A0Thomas