From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 75F773858C56 for ; Mon, 11 Dec 2023 13:14:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75F773858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 75F773858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300478; cv=none; b=sSfvuFIXtvTCLbbqF48sp+FQMnjYDdOcowqAxQs1Pt6cbj+Yn9Jp3MBrwCrs0kafPuulXutmqMaBTncBpRKREsOnGQI6Rih9WRToW0rVzJJlQzNSzbE6DdeLqQka7ZXL5rilfzo5Epri4kCYs7VSdnBKx/wRMx7BhQYDSKHvwv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300478; c=relaxed/simple; bh=SN+NP56XgIf7ABUnhz6DRPQ3x4WAfTaeCZGkB81N9gk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RBiurNeRFwq+T+0obVCYNdhsv2yKrs8YfVzmj9UoIk2dcf2rkh3Lt8E6K3fX0QJIeLRqoZmV0IB+lDcmZAa/6smeXW92h2fUc18/uGFWkFhJHbeUPzzFFhu8RGPmwHrozEXu7LzL6pjokttbQUm8Xj/M9A5h/IPP2lrNR3miFIY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a00c200782dso592856466b.1 for ; Mon, 11 Dec 2023 05:14:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702300475; x=1702905275; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xvd4NPG+cFQ0kfixWP3snV1nKM77i45Ee4bo0r/axKs=; b=Mqz1okwmubcvKTrhRJoQWh/fh860gz80tanzYuu4MgtdwEQmfmj77sQuyr//jNP1fH m3OsQH7qQbajHxGXk20JgF030nB/lCBjscGnr8ExL79wmFbVzqeAF1JS+xKwV9cF+35S bNqhlXL6olPG0o01xcFRrhIYH2GhWT4yt6AFnohm7tBa6rKFbwNITnKDdw99pTCN7wF2 E3k2U5tQu/z88H3shAZAIA8yEloQcxcW1/Jyxjnfbh/kBBScIhOc9X5xV/lq4LNCF2qP Uttj3ahS7pX7Layxf/XF6Qu5VTKibt2g+GF8IS/cWdOGiaVbLYmVE1DLEScS/EmYasgo dUvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702300475; x=1702905275; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xvd4NPG+cFQ0kfixWP3snV1nKM77i45Ee4bo0r/axKs=; b=M2AHNWaqQukUfWw7AWQraUE3UIK6FuspZ8WLu4f3RjpzCv5KqsBSxjUI2TK7h+49LY 6nECyHuK1XBxuMiSrxsFNRCNCf9nFct2Mfss9MJqYJFRwNcsW5K/r8XeeG8DicZ5qIvv xWnPRLNt8oQDQp5xQpiOVwJTeAyMuriyZ+FkSc4ot8gsSVMEwyrPKoEGksDk37gRRZ8g VXug6XmvYMnMIX++jegzuOP38OvNGz/2kClySi0z+Yfskc5VSPN60JWDDkVj2jWIFAIH tvHnPRd+6PdVlwDag9icZZSK5PJy7pAooFuMqVZxdoPFoO/sXKJNbaMcLQ37IhwSS3Py HwZw== X-Gm-Message-State: AOJu0YxMNBuXzDqaumf8m1dOpp0oIFO4hfCbybotHXQT50qxmvmws3VX P/hwVmp40QeKko+qRqse3x8= X-Google-Smtp-Source: AGHT+IGk/QGujfXE3LdMrbABc0TCPOoGmKr/nVKYTrbaVjqf7Q34rVHTaWX4JI36U16t+gwJ7vdK/g== X-Received: by 2002:a17:907:72cb:b0:a1d:9d7b:f2cf with SMTP id du11-20020a17090772cb00b00a1d9d7bf2cfmr1548759ejc.15.1702300475067; Mon, 11 Dec 2023 05:14:35 -0800 (PST) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id mn6-20020a1709077b0600b00a18374ade6bsm4800786ejc.67.2023.12.11.05.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 05:14:34 -0800 (PST) Message-ID: <1c53662b-5f59-4bb4-80be-a64676743db9@gmail.com> Date: Mon, 11 Dec 2023 14:14:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com Subject: Re: [PATCH] RISC-V: Add vectorized strcmp. Content-Language: en-US To: "Li, Pan2" , =?UTF-8?B?6ZKf5bGF5ZOy?= , gcc-patches , palmer , "kito.cheng" , Jeff Law References: <9B7FE9CAFC890D1F+202312020658356190086@rivai.ai> <6b17380b-5bd8-4399-bc5b-f90742478a8e@gmail.com> <42573221-a3ee-47db-9e6d-d5614f4fc861@gmail.com> <73FBA157619C75FC+2023120922033781725918@rivai.ai> <9460c00c-f895-461f-9cd3-7bde5cf8e4fb@gmail.com> <93547E3069E0817B+2023120922173619219621@rivai.ai> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_MANYTO,KAM_SHORT,RCVD_IN_DNSWL_NONE,SCC_5_SHORT_WORD_LINES,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Pan, > I reduced the SZ size from 10 to 1, and the below case with SZ = 2 > will fail. The failed location is "foo is 50, foo2 is 12800, i,j is > 1, 0". > > #define SZ 2 > > const char *s[SZ] = {"1", > "12345678901234567889012345678901234567890"}; Thanks. I still cannot reproduce but I think the reason is that foo2 (so the reference) does something different with newlib as opposed to libc. Could you try if the attached helps for you? Regards Robin diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/builtin/strcmp-run.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/builtin/strcmp-run.c index 6dec7da91c1..adbe022e0ee 100644 --- a/gcc/testsuite/gcc.target/riscv/rvv/autovec/builtin/strcmp-run.c +++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/builtin/strcmp-run.c @@ -1,8 +1,6 @@ /* { dg-do run } */ /* { dg-additional-options "-O3 -minline-strcmp" } */ -#include - int __attribute__ ((noipa)) foo (const char *s, const char *t) @@ -10,23 +8,26 @@ foo (const char *s, const char *t) return __builtin_strcmp (s, t); } -int -__attribute__ ((noipa, optimize ("0"))) -foo2 (const char *s, const char *t) -{ - return strcmp (s, t); -} - #define SZ 10 -int main () +int +main () { const char *s[SZ] = {"", "asdf", "0", "\0", "!@#$%***m1123fdnmoi43", "a", "z", "1", "9", "12345678901234567889012345678901234567890"}; + const int ref[SZ * SZ] + = {0, -97, -48, 0, -33, -97, -122, -49, -57, -49, 97, 0, 49, 97, 64, + 115, -25, 48, 40, 48, 48, -49, 0, 48, 15, -49, -74, -1, -9, -1, + 0, -97, -48, 0, -33, -97, -122, -49, -57, -49, 33, -64, -15, 33, 0, + -64, -89, -16, -24, -16, 97, -115, 49, 97, 64, 0, -25, 48, 40, 48, + 122, 25, 74, 122, 89, 25, 0, 73, 65, 73, 49, -48, 1, 49, 16, + -48, -73, 0, -8, -50, 57, -40, 9, 57, 24, -40, -65, 8, 0, 8, + 49, -48, 1, 49, 16, -48, -73, 50, -8, 0}; + for (int i = 0; i < SZ; i++) for (int j = 0; j < SZ; j++) - if (foo (s[i], s[j]) != foo2 (s[i], s[j])) + if (foo (s[i], s[j]) != ref [i * SZ + j]) __builtin_abort (); }