From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by sourceware.org (Postfix) with ESMTPS id EE3ED3858D1E for ; Fri, 23 Dec 2022 19:36:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE3ED3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ispras.ru Received: from [10.10.3.121] (unknown [10.10.3.121]) by mail.ispras.ru (Postfix) with ESMTPS id DAB5E40737B8; Fri, 23 Dec 2022 19:36:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru DAB5E40737B8 Date: Fri, 23 Dec 2022 22:36:04 +0300 (MSK) From: Alexander Monakov To: Qing Zhao cc: Jose Marchesi , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH V2] Disable sched1 in functions that call setjmp In-Reply-To: <5FA6D04C-0D5F-4E51-A05D-A2D9370958B0@oracle.com> Message-ID: <1c5ab216-dd76-caf6-b1d7-4f02a2feb5e5@ispras.ru> References: <20221222173208.13317-1-jose.marchesi@oracle.com> <53b93d7e-a157-9116-d07a-4d51cd43d205@ispras.ru> <35CA4F79-CA10-4560-8920-CDA65810E308@oracle.com> <87h6xmyqqq.fsf@oracle.com> <3183d104-b852-eb38-d5ba-9578594015bd@ispras.ru> <5FA6D04C-0D5F-4E51-A05D-A2D9370958B0@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 23 Dec 2022, Qing Zhao wrote: > Then, sched2 still can move insn across calls? > So does sched2 have the same issue of incorrectly moving the insn across a call which has unknown control flow? I think problems are unlikely because register allocator assigns pseudos that cross setjmp to memory. I think you hit the problem with sched1 because most testing is done on x86 and sched1 is not enabled there, otherwise the problem would have been noticed much earlier. Alexander