From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 07BA83857027 for ; Wed, 4 Oct 2023 17:38:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07BA83857027 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1c61bde0b4bso20507325ad.3 for ; Wed, 04 Oct 2023 10:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1696441121; x=1697045921; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MaLl+EM0dKdJrAu5VhnjUlgxj3NTmWAHJ7gtQTgoyk4=; b=QNEj0uJXhVTGTn6KzuSi/tM15kOzXckRzpGnvLNXKophBovs9cwbqvWL/xx4wYik0w gY1zOMvWqOCPS+CnUH66KrJ8oHI3nZPIpoN0a3Y4JcLmPF18bl/xgxt5wJT/Z0bI/yWv ZSzWJ0/yPD7OC6UNOHqvyegsMxPNbDbhf2mxzjiPh97jk5PL0ZY59hL0tJk1r5n+tA45 GJo0nD/xesufv1ToRKIG3RIK1XKxc01jNib1udZGcqc0a4xfDR5iffOXz/Ul41ye9cIg C8ZPYXtUbfVJLDC5E8ahsUbc5C3d8eULyH/3QPI2sJ67EmReah+5f2yh4oITKkDvQxI8 p3zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696441121; x=1697045921; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MaLl+EM0dKdJrAu5VhnjUlgxj3NTmWAHJ7gtQTgoyk4=; b=NLUuctU+tfJzFjy4oBba7l7l0O4ap1cBHzUwgC/9oqUGFTT8bKroq/IuEH96lXZ2Fm JRVWWBcjOMyf3dvSqptRBABztHLNYLJJ9kSjTLjjtmtR9q5MBMgqsXjmS2836phFyiSn 0padsHm7MCwkBa5GXRuuDgq2DhPNTl/NgT7KlxEDyA1Oi8ku1xHrkHLHwDyLiagne6B4 DQDZNNPggXDOVdQErnekhuRnYnaq2/XEZ9G41AypZ75h5EStPYC1xV8Uxi6m2O9n+8rk JR89bK8pCUl+XNVdAJeuX3fhE1y1Hy6HYCNQxOc+LvZJ4ZVhBMDr+G3G+R3OFgIvYlKK PWCA== X-Gm-Message-State: AOJu0YyvnJAt0TFRHCshrybIp5cbx4WJkaoSp9tElDWk7EKFYLxTyr1V Nu1TXcl8EyY2IyYg5mdqFroBog== X-Google-Smtp-Source: AGHT+IFbtB74P7O5PvCTAxu+AZonflz+6KB4s7/4LB6CdJRHfqGL5KddleOTgKbVjElBXnuVjsPVyA== X-Received: by 2002:a17:902:c94e:b0:1c7:245a:7fea with SMTP id i14-20020a170902c94e00b001c7245a7feamr4165988pla.58.1696441120827; Wed, 04 Oct 2023 10:38:40 -0700 (PDT) Received: from ?IPV6:2601:647:5700:6860:5d01:b505:51d5:3b5e? ([2601:647:5700:6860:5d01:b505:51d5:3b5e]) by smtp.gmail.com with ESMTPSA id j13-20020a170902c3cd00b001b03f208323sm3997319plj.64.2023.10.04.10.38.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 10:38:40 -0700 (PDT) Message-ID: <1c7393c8-e17d-cf12-d051-acc9599d3669@rivosinc.com> Date: Wed, 4 Oct 2023 10:38:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RISC-V]: Re: cpymem for RISCV with v extension Content-Language: en-US To: Joern Rennecke , GCC Patches Cc: "juzhe.zhong@rivai.ai" , "kito.cheng" , "Kito.cheng" , Robin Dapp , Jeff Law References: <1525C65921357A3C+2023080507101006323211@rivai.ai> <5814e96a-9d86-d428-cf48-ec1ab80eb2d9@gmail.com> <960B8F718A41FF46+2023080507344044042924@rivai.ai> <91d19edb-6e56-b538-a0c3-3a322dba80ad@gmail.com> From: Patrick O'Neill In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Joern, I'm seeing new failures introduced by this patch (9464e72bcc9123b619215af8cfef491772a3ebd9). On rv64gcv: FAIL: gcc.dg/pr90263.c scan-assembler memcpy FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,  -O2 -fomit-frame-pointer -finline-functions -funroll-loops Debug log for intrinsic_count.f90: spawn riscv64-unknown-linux-gnu-run /scratch/tc-testing/tc-410-break/build/build-gcc-linux-stage2/gcc/testsuite/gfortran9/intrinsic_count.x STOP 2 FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,  -O2 -fomit-frame-pointer -finline-functions -funroll-loops It's worth noting that intrinsic_count.f90 had failures prior to this patch for other option combinations: FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,  -O2 FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,  -O2 -fbounds-check FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution,  -O2 -fomit-frame-pointer -finline-functions Thanks, Patrick On 10/1/23 19:43, Joern Rennecke wrote: > On Tue, 15 Aug 2023 at 15:06, Jeff Law wrote: > > >> On 8/15/23 03:16, juzhe.zhong@rivai.ai wrote: >>> The new patch looks reasonable to me now. Thanks for fixing it. >>> >>> Could you append testcase after finishing test infrastructure ? >>> I prefer this patch with testcase after infrastructure. >> So let's call this an ACK, but ask that Joern not commit until the >> testsuite bits are in place. > Beyond the adding of tests, the patch needed some changes because of the > Refactoring of emit_{vlmax,nonvlmax}_xxx functions . > Attached is the committed version.