From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id C7643385840D for ; Thu, 27 Oct 2022 22:47:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C7643385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x632.google.com with SMTP id v17so155366plo.1 for ; Thu, 27 Oct 2022 15:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1NROueBUujf8GaOTVUrhFCYhytXQRD13cmkrgUBt1e0=; b=MOFT+gQDe+jO94htOp10+rrzNkWfWWaLkncGPVKaoqE3mby5TMqnNRhFm/Zp2hRnkb Jt+6C3GFXUeC6PFgS0z0RmfSyta92ElaQi+QjY7gl7nM7lULUvSeTmpuhh63iUMVxX/0 ffub8a5CuqgaQj6fuFqEio3cIPETJZT2ykgCKBlgO31YHsw0IDUh2HWMy8sjy/loUfP5 q0siQBpIc2By90towGbnzqyvFZ+iYN1P5JUyty8hkNWN6gYm7BYhQH7y2+wTG8EH2hXq KER3L8Rb+ed7ghsDQbPk+A3V3Bopl3BU8LTt431oSjIszaRygv7pgnQ35elYaFU2rB/S NLjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1NROueBUujf8GaOTVUrhFCYhytXQRD13cmkrgUBt1e0=; b=EvvaHDKZWMsLA9Bwt4P7fXx0R28iaxb2XsHZt8j7BjBnrJBvuPOdmRssuxvdKZJ5Bp 9Detbjpqt+AyK9DtJA7/mHpajVOJo2YyIXjmbkjSazXJK3vqElT4KtVceCumPeIh/+iL cpKfSLn3FLgzIXQMlW57Tig/nwkhOiYZ70L3gdCeZEo6rLN1pE6ZtykZSkh1ECwRpbXY x0ytr0NTqL9bfuininnprAAemDBcfr4/k7ZWMrsXbx5PcyPatGGsUB6/hSxoeheTd5s8 OaUmpxUAoE3dHgJlaPE2r3M28brpj/7eVdysH2l3OwNtIHNKAZFbzlIybXOp8yq1/GvL rbZA== X-Gm-Message-State: ACrzQf2X+WnuUvOR4lIkBlKcS6LM1vQMBgP8IujyMCqlAttVg1TSJYV/ pMJ13f7VFzM1iVXKTFDA7nR5OQl1VFg= X-Google-Smtp-Source: AMsMyM4adzpMZe5Xrr5VJ9iUBRO3gMeE2gOvWW8DkJBlx3mrrj6C2cliKuXWXUwvA2LS1pztJboveg== X-Received: by 2002:a17:902:d4cc:b0:186:f57d:ba61 with SMTP id o12-20020a170902d4cc00b00186f57dba61mr2103026plg.97.1666910820311; Thu, 27 Oct 2022 15:47:00 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id u13-20020a170902e80d00b001869394a372sm1697184plg.201.2022.10.27.15.46.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 15:46:59 -0700 (PDT) Message-ID: <1c75b0d5-74e9-d63b-ebdd-76a4f2dc6153@gmail.com> Date: Thu, 27 Oct 2022 16:46:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Change constexpr back to CONSTEXPR Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20221027144152.335455-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20221027144152.335455-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/27/22 08:41, juzhe.zhong@rivai.ai wrote: > From: Ju-Zhe Zhong > > According to https://github.com/gcc-mirror/gcc/commit/f95d3d5de72a1c43e8d529bad3ef59afc3214705. > Since GCC 4.8.6 doesn't support constexpr, we should change it back to CONSTEXPR. > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins-bases.cc: Change constexpr back to CONSTEXPR. > * config/riscv/riscv-vector-builtins-shapes.cc (SHAPE): Ditto. > * config/riscv/riscv-vector-builtins.cc (struct registered_function_hasher): Ditto. > * config/riscv/riscv-vector-builtins.h (struct rvv_arg_type_info): Ditto. OK.   Please install. Maybe we can move past gcc-4.8 as a bootstrapping requirement one day ;-) Jeff