From: Xi Ruoyao <xry111@xry111.site>
To: Lulu Cheng <chenglulu@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: Wang Xuerui <i@xen0n.name>, Chenghua Xu <xuchenghua@loongson.cn>,
Xiaolin Tang <tangxiaolin@loongson.cn>
Subject: Re: [PATCH 2/4] LoongArch: Add ftint{,rm,rp}.{w,l}.{s,d} instructions
Date: Wed, 09 Nov 2022 16:14:37 +0800 [thread overview]
Message-ID: <1c8436863493d9a3abfbda035f75ff35272a5358.camel@xry111.site> (raw)
In-Reply-To: <4c43dfab-7562-8d7a-5186-e2c1b7f181a9@loongson.cn>
On Wed, 2022-11-09 at 15:46 +0800, Lulu Cheng wrote:
> There is a paragraph in the explanation information for the compile
> parameter '-fno-fp-int-builtin-inexact' in the gcc.pdf document:
>
> "Do not allow the built-in functions ceil, floor, round and
> trunc,
> and their float and long double variants,
>
> to generate code that raises the “inexact” floating-point
> exception
> for noninteger arguments.
>
> ISO C99 and C11 allow these functions to raise the “inexact”
> exception, but ISO/IEC TS 18661-1:2014,
>
> the C bindings to IEEE 754-2008, as integrated into ISO C2X, does
> not allow these functions to do so."
>
> So I think the implementation of these functions needs to be confirmed
> again.
>
> Or am I misinterpreting this description?:-[
You are correct, I'm wrong :(.
This patch breaks:
long x(double d)
{
return __builtin_ceil(d);
}
The compiler then folds it into __builtin_lceil and produce
ftintrp.l.d $f0,$f0, even if -fno-fp-int-builtin-inexact is used.
I'll revise this patch to limit lceil and lfloor for -ffp-int-builtin-
inexact only.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-11-09 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 7:21 [PATCH 0/4] LoongArch: Add some floating-point operations Xi Ruoyao
2022-11-09 7:21 ` [PATCH 1/4] LoongArch: Rename frint_<fmt> to rint<mode>2 Xi Ruoyao
2022-11-09 7:21 ` [PATCH 2/4] LoongArch: Add ftint{,rm,rp}.{w,l}.{s,d} instructions Xi Ruoyao
2022-11-09 7:46 ` Lulu Cheng
2022-11-09 8:14 ` Xi Ruoyao [this message]
2022-11-09 7:21 ` [PATCH 3/4] LoongArch: Add fscaleb.{s,d} instructions as ldexp{sf,df}3 Xi Ruoyao
2022-11-09 7:21 ` [PATCH 4/4] LoongArch: Add flogb.{s,d} instructions and expand logb{sf,df}2 Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8436863493d9a3abfbda035f75ff35272a5358.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=tangxiaolin@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).