From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id 2161F3857C51 for ; Fri, 18 Nov 2022 19:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2161F3857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1036.google.com with SMTP id d13-20020a17090a3b0d00b00213519dfe4aso5966175pjc.2 for ; Fri, 18 Nov 2022 11:26:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gGKV5qXb/zlv8GKJ6mvwmUFWqHCOkO1Ync5RMDzBOi8=; b=qN83Ll3tWJvR1WX8Rge0I7scGHaZSBFhen00opi6kVhBI0XBtO0HRFwVNuBRCnxcC7 aFi2wWJswNzcwrnhn8oucPY1R2XmgQ/WtiWlEMh4Pmro3Tn4eaxyDhbcxcaGIJXGQE5N 6m75KYhwZTJwL1Ywpo2tSPgp3Jg/a7i0pUa5dGsxr1sr0PRBwVgdU6u2mNl23gqFo2xf 4YBTpKiNUKtW6Z1AVzso6TP+RhX2lEMszu48AHKw5c3+qOC6rk86glulyU/IaS2Bs5CE ZyvLraklSzaz9HJPtUTqUw9bIsONpPLRF2aCS84cE90DgL4apM0YSP5nnkjTB/pYgVlU llGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gGKV5qXb/zlv8GKJ6mvwmUFWqHCOkO1Ync5RMDzBOi8=; b=FtsUlJMoKXZpvQTJu+KoBnduIwfkk2V24TDjLCIUEpgQV0o023DCORL7ZlBb9GYaMp Aah2yRIyDtNmvMv3zfi4Vc0syZpo4WVmg/1AdFa7LgoMqXKCy62MUr97oNpGjfxK1//V CYt4SQFaYvFxPzObpYLTDAGG5ea8dY3fySLuqr3Gpp1Mn1BsSrM/b/GKfnXMYvW0kZIk 8LDE7WS23lub8QALzPn7C0r0DH4zFJ9yVrArZy0LSEqEfPn98C4K+bDTGMluifBDdtf3 zG4LOD1vyDTILboWjJCjtjJsySpiLt4y0rzj+l2JqtwYq5ZiNAFdyHWHpaLgAozam722 5jyg== X-Gm-Message-State: ANoB5pmxozqCUch1GodqRPtRjFKdrqbvcdSHwgXrwjUDAZrsIPtIA8/R HAWVYWo7BxxJ5pF9f0X8yO8= X-Google-Smtp-Source: AA0mqf6LLVbSPGZgYHhEr7yFcx8IdACrqlUYt2TpkCJVcFYEvQDzliQONPK5tfJTWKZVYikcyO9hsw== X-Received: by 2002:a17:902:e492:b0:186:5f71:7939 with SMTP id i18-20020a170902e49200b001865f717939mr813146ple.162.1668799588932; Fri, 18 Nov 2022 11:26:28 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id y10-20020a17090322ca00b0017bb38e4588sm4139819plg.135.2022.11.18.11.26.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 11:26:28 -0800 (PST) Message-ID: <1c84ef1d-2090-2a93-d391-c8a9b765609d@gmail.com> Date: Fri, 18 Nov 2022 12:26:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: allow bseti on SImode without sign-extension Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Christoph Muellner , Vineet Gupta , Palmer Dabbelt , Jeff Law , Kito Cheng References: <20221108200323.2719563-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20221108200323.2719563-1-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_LINKBAIT3,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/22 13:03, Philipp Tomsich wrote: > As long as the SImode operand is not a partial subreg, we can use a > bseti without postprocessing to or in a bit, as the middle end is > smart enough to stay away from the signbit. > > gcc/ChangeLog: > > * config/riscv/bitmanip.md (*bsetidisi): New pattern. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/zbs-bexti-02.c: New test. OK, with my usual grumble about SUBREGs. jeff