From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 081A73858D37 for ; Wed, 28 Jun 2023 14:19:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 081A73858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1b7ffab9454so21403585ad.3 for ; Wed, 28 Jun 2023 07:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687961950; x=1690553950; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/k537eDLImG9RUW9yCeZCwep35ityriV4IIgvt5ZOu8=; b=pouzIahsCc6vsypeObUvodObAMmyGKuqO7Rz411FqD2/Odh3cZq55V0SNWaXfrotJz 70K5cjNGnVuUv7vIDGzE6QYT0Rz4+1Sa0u7YzCTtYVWSPTCgMtzGDCEIgCEKUa6xkxo2 A8VFzEy6C8wFwyeAGlaScH3xlOSs/fqz/YBt8k7ESzOAc6yApYWfVB8SeozMkLFesItg 956GLKUaFZSnYo6xahS0xCCY02C2ntB5KOXSqzbFhFUUS2X4W2gkmOvyCQF5B3k4+HhC cW2e1pbAxpXTbTlrjM0XM5ipcmZ1eOq2RHK1+YIUgZDDBqjojnewWOfF/L44o3xAVtM1 IXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687961950; x=1690553950; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/k537eDLImG9RUW9yCeZCwep35ityriV4IIgvt5ZOu8=; b=Ok9E7d04vjGSwZWRBkrFhfYRR/yduUGDqkBfHa8WFuijgIKiCauU/3XKGyopbUP+dm QsI7aOPse6fEqGKPS6NpkymmvteLERhqA6WZ6LKXTyg/hnh25MNHqS1EyAYwb8iwIqiB 46pBL5uHKIDy6/cBOuqbRaje8Q5VgQtSvn1NHli1DEEiQ4UBwxTHA1K5iso8q7tlvTIc F92KwicbzCM7kih1xV22RMo4xyM3rI7j0+DkWhY9ojBFtCYQnVrC2voRovE0C3AAtLgg hjwICWamdeTyhozzw69U2hd0y3nVASPPBxaEiKfE49ft8aWL6gFZiKzKGaekAlxpTu6u k1OA== X-Gm-Message-State: AC+VfDwrJ4izteaHtz58uh4d/JolbR4rYnE4TbdIDxGrarACLTHnWMln oBsEYvxxXX6RnZ/VFzQsmvE= X-Google-Smtp-Source: ACHHUZ45V/aYpmxRM4B9LxlhwRzfAQeQZdAfCPbHiQfjReVPVIhNPdD4APLqsWGJHpEiH041cbP59A== X-Received: by 2002:a17:903:503:b0:1b7:f543:cea2 with SMTP id jn3-20020a170903050300b001b7f543cea2mr7878902plb.1.1687961949981; Wed, 28 Jun 2023 07:19:09 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id jh13-20020a170903328d00b001b80fe91a40sm4414181plb.272.2023.06.28.07.19.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jun 2023 07:19:09 -0700 (PDT) Message-ID: <1cb42ba7-effe-f477-2a1a-2f6c59ebbce9@gmail.com> Date: Wed, 28 Jun 2023 08:19:07 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] tree-optimization/110434 - avoid ={v} {CLOBBER} from NRV Content-Language: en-US To: Richard Biener , gcc-patches@gcc.gnu.org Cc: Jakub Jelinek References: <20230628102159.84C093858412@sourceware.org> From: Jeff Law In-Reply-To: <20230628102159.84C093858412@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/28/23 04:21, Richard Biener via Gcc-patches wrote: > When NRV replaces a local variable with it also replaces > occurences in clobbers. This leads to being clobbered > before the return of it which is strictly invalid but harmless in > practice since there's no pass after NRV which would remove > earlier stores. > > The following fixes this nevertheless. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK? > > Thanks, > Richard. > > PR tree-optimization/110434 > * tree-nrv.cc (pass_nrv::execute): Remove CLOBBERs of > VAR we replace with . OK. jeff