From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 13586386186A for ; Sun, 7 Jan 2024 19:11:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13586386186A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13586386186A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704654688; cv=none; b=X3MIjlnAKdn1VlBz/JGbf7A2A18nSRwz1bFvTh2lsiHgILIYA/O//takkWGnya7N3rntHfK7F0b8UZ3sxoJDehtX7PgW4QG0vk2stNPW0A5106mq/0fb/7RO0d7BvzYyr3bRup9dWOhEdVrhdIe0WVdswSuAFXjUCgBN9yci+VM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704654688; c=relaxed/simple; bh=ITEhq9TKr0vjpZnkBhk6p725CpflnsmyyDwlGKmHKJ8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=BIMWAkfC+dQ5oDMuFEQ8Auz3RCMqUidCEtm6cvK+iO0yrwStOiF7diZEakFs830M7dp30s9BC6wFkJhSmDkFTf1f1d6F3ElM9IDqmYZTwnNS96e/5s+zqWA++OyyIHauCsu+fmeC07iGmfv3YJuyXK+OTXCXJDXe7Hr6CO+dG4k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7bc332d49f6so66918239f.1 for ; Sun, 07 Jan 2024 11:11:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704654686; x=1705259486; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VGIp6evbCDxJajOw0mmOMH4WqZp8LVXpQGScbxUpjB0=; b=f93OfkLTXG8HMOzIcjSd0SZydd5uN/luiHmanmou23htds9ATJk93VeHJwdustQikm 38MqC4jW6H077llCvqZiWVDVjp3ZPNM4+Vd3d6bWTmEKUDfUuimjtZPDCIZ7Nl2HIplz A+kq7tIJfzTczuN+v5Ee7W+hxepSpLoFY/tIDK/ZegWAmwM67QuQ6tLJSopNswJ4nAlv Gaiufdtqc6YOxNu6uFVelmc+k5E2XOX/JFbrt3za5MnfkEm0cOU+bFoQcKvrcxYP/Dp5 /0mbz0Rxp2rlcvVbsoRLhp8GZN4B5f6uKZmG7vAuvpbe6iJ7cDyuX26nbN4PBgaJgqqD CF+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704654686; x=1705259486; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VGIp6evbCDxJajOw0mmOMH4WqZp8LVXpQGScbxUpjB0=; b=PbRqTsey9ZIL8ugoA5+8j4nd6yr+SRp7iA9MK1nB6mhGAloG1KRI1wtaeR5mCwdgsp /IFkhXP/l75D1yrql1QN290zGbn4RD/SS+RkTStNG5b5UxF0HpGDipJce9qPpYr/Tdi4 YE9rRE5x2cO4G38nuqGB7xB6OsFsBwx7Ozk34iS/Nz+9nkgCwZDxLi4dPmSCUZxYIxw5 i8n+qpLYZHF9UV/diW43+fMLvgAP0N88O6doLNZ1mjs4Sr5bGmCsEiyao8NbC980/0ZK fLDlxuSWfGN9W2/w1hXNeiRGRnp3+1D3B1mimRgrscIectdbHB8tiUBthpqZXKWCX6Cl wdVg== X-Gm-Message-State: AOJu0Yy4HXL3Wxa7v7p7kRxRaT639ubR3ZlRG820z2txJHouUZAuOhWR C1H/9gebZOL4tEsiQCBHvpV5/Dj5sOo= X-Google-Smtp-Source: AGHT+IETbquQLLc4pCszcc4lDgaiTJ9war1FwFVLDEK2xanFDpBeJ3gpAh/6i50z72xeVAOsqlx9Jw== X-Received: by 2002:a05:6602:14ce:b0:7bc:17b2:e500 with SMTP id b14-20020a05660214ce00b007bc17b2e500mr5421747iow.4.1704654686169; Sun, 07 Jan 2024 11:11:26 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id dn14-20020a056638090e00b0046d17aff31bsm1775703jab.157.2024.01.07.11.11.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jan 2024 11:11:25 -0800 (PST) Message-ID: <1cfa6078-0cfc-4192-b44f-a0751babe6aa@gmail.com> Date: Sun, 7 Jan 2024 12:11:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS] Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20240107003654.1629705-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20240107003654.1629705-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/6/24 17:36, Juzhe-Zhong wrote: > Obvious fix, Committed. > > gcc/ChangeLog: > > * config/riscv/riscv-vsetvl.cc: replace std::max by MAX. Curious why you made this change -- in general we're moving to std::{min,max,swap} and away from macro-ized min/max/swap. Jeff