From: Jeff Law <jeffreyalaw@gmail.com>
To: Tom Tromey <tom@tromey.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 11/21] libcc1: unify compiler handling
Date: Thu, 29 Apr 2021 06:47:34 -0600 [thread overview]
Message-ID: <1d137016-46a0-8859-3a4c-f4ede20010eb@gmail.com> (raw)
In-Reply-To: <20210428010119.806184-12-tom@tromey.com>
On 4/27/2021 7:01 PM, Tom Tromey wrote:
> Both libcc1 plugins have nearly identical copies of code to find the
> underlying compiler. This seemed wasteful to me, so this patch
> unifies the copies.
>
> Two minor API changes were needed.
>
> First, the old code used a back-link from the compiler object to the
> plugin object to check the 'verbose' setting. This patch adds a
> 'verbose' setting directly to the compiler object instead.
>
> Second, the 'find' method implicitly knew which compiler base name
> ("gcc" or "g++") to use. This patch makes this a parameter that is
> passed in by the plugin.
>
> libcc1/ChangeLog
> 2021-04-27 Tom Tromey <tom@tromey.com>
>
> * libcc1.cc (compiler, compiler_triplet_regexp)
> (compiler_driver_filename): Remove.
> (libcp1::libcp1): Update.
> (make_regexp, libcp1::compiler::find)
> (libcp1::compiler_triplet_regexp::find)
> (libcp1::compiler_driver_filename::find): Remove.
> (libcp1_set_verbose, libcp1_set_arguments)
> (libcp1_set_triplet_regexp, libcp1_set_driver_filename): Update.
> * libcc1.cc (compiler, compiler_triplet_regexp)
> (compiler_driver_filename): Remove.
> (libcc1::libcc1): Update.
> (make_regexp, libcc1::compiler::find)
> (libcc1::compiler_triplet_regexp::find)
> (libcc1::compiler_driver_filename::find): Remove.
> (libcc1_set_verbose, libcc1_set_arguments)
> (libcc1_set_triplet_regexp, libcc1_set_driver_filename): Update.
> * compiler.cc: New file.
> * compiler.hh: New file.
> * Makefile.in: Rebuild.
> * Makefile.am (libcc1_la_SOURCES): Add compiler.hh, compiler.cc.
OK
Jeff
next prev parent reply other threads:[~2021-04-29 12:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 1:00 [PATCH v2 00/21] C++11-based improvements for libcc1 Tom Tromey
2021-04-28 1:00 ` [PATCH v2 01/21] libcc1: use templates to unmarshall enums Tom Tromey
2021-04-28 18:27 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 02/21] libcc1: use "override" Tom Tromey
2021-04-28 15:53 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 03/21] libcc1: inline some simple methods Tom Tromey
2021-04-28 15:54 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 04/21] libcc1: delete copy constructor and assignment operators Tom Tromey
2021-04-28 15:55 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 05/21] libcc1: use variadic templates for "call" Tom Tromey
2021-04-28 18:28 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 06/21] libcc1: use variadic templates for "rpc" Tom Tromey
2021-04-28 18:28 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 07/21] libcc1: use std::vector when building function types Tom Tromey
2021-04-28 16:01 ` Jeff Law
2021-04-28 19:56 ` Tom Tromey
2021-04-28 20:07 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 08/21] libcc1: add deleter objects Tom Tromey
2021-04-28 21:06 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 09/21] libcc1: add more uses of 'deleter' Tom Tromey
2021-04-29 12:43 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 10/21] libcc1: use unique_ptr more Tom Tromey
2021-04-29 12:44 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 11/21] libcc1: unify compiler handling Tom Tromey
2021-04-29 12:47 ` Jeff Law [this message]
2021-04-28 1:01 ` [PATCH v2 12/21] libcc1: use foreach Tom Tromey
2021-04-28 16:04 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 13/21] libcc1: use static_assert Tom Tromey
2021-04-28 16:06 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 14/21] libcc1: share basic context code Tom Tromey
2021-04-29 12:50 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 15/21] libcc1: share GDB plugin code Tom Tromey
2021-04-30 14:50 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 16/21] libcc1: use GCC_FE_VERSION_1 in C++ plugin Tom Tromey
2021-04-28 16:06 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 17/21] libcc1: share the GCC interface code Tom Tromey
2021-04-30 15:07 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 18/21] libcc1: fix a memory leak Tom Tromey
2021-04-28 16:07 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 19/21] libcc1: use variadic templates for callbacks Tom Tromey
2021-04-30 15:08 ` Jeff Law
2021-05-04 22:05 ` Tom Tromey
2021-04-28 1:01 ` [PATCH v2 20/21] libcc1: avoid extra string copies Tom Tromey
2021-04-28 16:07 ` Jeff Law
2021-04-28 1:01 ` [PATCH v2 21/21] libcc1: avoid a call to c_str Tom Tromey
2021-04-28 16:08 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d137016-46a0-8859-3a4c-f4ede20010eb@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).