From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by sourceware.org (Postfix) with ESMTPS id B01DF3AA843F for ; Thu, 17 Nov 2022 14:30:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B01DF3AA843F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf34.google.com with SMTP id e15so1278148qvo.4 for ; Thu, 17 Nov 2022 06:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7Izw7Skc/uEdM+Jn/6vCRUtJr1UtnHprcB1W7QZbEKI=; b=WX0fuJoNUtN3zuZJk5c6dDuABewluGVOqR6i+MeyRFYrV1k3AmHo8iOUffgU/xWaiv 32gVYQx0Hl5CMZ+62ty+Q1wuhbFkV0kxZBf89PPv6CHGfbIlY5Id4Khz4MSbaL9ot42Z kT9v0pFg3gTvMPPXVtKMAMeKiYvoBa+NQP30ODae0s3LbxfftpuVHQlc3XifD55Gb3AI xGAwx78GQZLJULV4WzmSBrR5D6/92UUpLka6fq/U9r0GOnljEFaiP1T4PQbUpAniGtAA cMYdd1DEYbX+oK0taRwJdcYxIJzqeNYJkDf1CySEb+5G5ZZhqFyg+iVd/zc9Dml5Nxz2 ud8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7Izw7Skc/uEdM+Jn/6vCRUtJr1UtnHprcB1W7QZbEKI=; b=fezENenI6/18vkOintq61A9iGKTP43xk9KZEKQxfOSd8sciGTbnRM26xDVb+PsTMW7 X5WKiscADeUHNU6187tE0HrK8v0Mxo6VtqVrNWOM5X3Ruok8LLsPyvQPWbDrVjBPMkLO zY5cjnzPciLDS+RXeNm4TdsOXI5W4M7IAJ+uBZFsxeZlDmusqZG2OyKQqVuVqZD6cKMR EAE5eTiMePI2uBMMh+2505I6yxyiJ85aesWbqQeeqySxfXfQsi6lZtxhq6bN/OgQvQcR dySFjBRR0JX/5iPZkBtnKlCaUn/Hh9AA5eTOSgkDS0wZSaxYUe7mFnwqGcxXDmG0fyjK 5wvg== X-Gm-Message-State: ANoB5plBR5dRtIEcVT4bONo/ORn21d1dbEmFnPqwwKiq+6Q08hh353cV a/VczUxTcZRPjgVpoJEzM9M= X-Google-Smtp-Source: AA0mqf7tN58CrQRgvSJ7qknVZZUFLwP4BBClTJVmbN6ct/V7Mz9jfoPMeHVliCf0fr+v7Ec0N6zwmA== X-Received: by 2002:a05:6214:368a:b0:4bb:6b58:2c96 with SMTP id nl10-20020a056214368a00b004bb6b582c96mr2561550qvb.127.1668695417884; Thu, 17 Nov 2022 06:30:17 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id bp44-20020a05620a45ac00b006fb93acc788sm553214qkb.6.2022.11.17.06.30.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 06:30:17 -0800 (PST) Message-ID: <1d164b26-57b6-8c17-18cd-79e8dc77d29d@gmail.com> Date: Thu, 17 Nov 2022 07:30:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Optimize masking with two clear bits not a SMALL_OPERAND Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Jeff Law , Palmer Dabbelt , Christoph Muellner , Kito Cheng , Vineet Gupta References: <20221110213617.3592572-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20221110213617.3592572-1-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/10/22 14:36, Philipp Tomsich wrote: > Add a split for cases where we can use two bclri (or one bclri and an > andi) to clear two bits. > > gcc/ChangeLog: > > * config/riscv/bitmanip.md (*bclri_nottwobits): New pattern. > (*bclridisi_nottwobits): New pattern, handling the sign-bit. > * config/riscv/predicates.md (const_nottwobits_operand): > New predicate. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/zbs-bclri.c: New test. Don't we only have to worry about (subreg:DI (reg:SI )) to preserve the extension constraints?  Not that I think there's any value in allowing HI/QI, mostly wanting to double check my understanding of the extension constraints. OK jeff