From: Jeff Law <jeffreyalaw@gmail.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] Allow subtarget customization of CC1_SPEC
Date: Sun, 20 Nov 2022 09:57:50 -0700 [thread overview]
Message-ID: <1d880015-d502-a393-6278-4281cf64504b@gmail.com> (raw)
In-Reply-To: <a4c1c0ab-ac34-09f8-6146-58927632f4aa@embedded-brains.de>
On 10/26/22 03:34, Sebastian Huber wrote:
> On 04/10/2022 11:47, Sebastian Huber wrote:
>> On 08/09/2022 07:33, Sebastian Huber wrote:
>>> On 04/08/2022 15:02, Sebastian Huber wrote:
>>>> On 22/07/2022 15:02, Sebastian Huber wrote:
>>>>> gcc/ChangeLog:
>>>>>
>>>>> * gcc.cc (SUBTARGET_CC1_SPEC): Define if not defined.
>>>>> (CC1_SPEC): Define to SUBTARGET_CC1_SPEC.
>>>>> * config/arm/arm.h (CC1_SPEC): Remove.
>>>>> * config/arc/arc.h (CC1_SPEC): Append SUBTARGET_CC1_SPEC.
>>>>> * config/cris/cris.h (CC1_SPEC): Likewise.
>>>>> * config/frv/frv.h (CC1_SPEC): Likewise.
>>>>> * config/i386/i386.h (CC1_SPEC): Likewise.
>>>>> * config/ia64/ia64.h (CC1_SPEC): Likewise.
>>>>> * config/lm32/lm32.h (CC1_SPEC): Likewise.
>>>>> * config/m32r/m32r.h (CC1_SPEC): Likewise.
>>>>> * config/mcore/mcore.h (CC1_SPEC): Likewise.
>>>>> * config/microblaze/microblaze.h: Likewise.
>>>>> * config/nds32/nds32.h (CC1_SPEC): Likewise.
>>>>> * config/nios2/nios2.h (CC1_SPEC): Likewise.
>>>>> * config/pa/pa.h (CC1_SPEC): Likewise.
>>>>> * config/rs6000/sysv4.h (CC1_SPEC): Likewise.
>>>>> * config/rx/rx.h (CC1_SPEC): Likewise.
>>>>> * config/sparc/sparc.h (CC1_SPEC): Likewise.
>>>>
>>>> Could someone please have a look at this patch set?
>>>
>>> Ping
>>
>> Would someone mind having a look at this patch set? If there is a
>> better approach to customize the default TLS model, then please let
>> me know.
>
> It would be nice if someone could review the patch before the Stage 1
> ends at November 13th.
Just a reminder. The guidelines are a patch needs to be posted before
the end of stage1 to make the deadline. Review & integration can happen
after the deadline.
I realize the idea here is to allow RTEMS to change the default TLS
model. But does it also happen to make it possible to solve Keith
Packard's issues with picolibc? See the Aug/Sep gcc-patches archives.
It looks sensible. I assume you did a "find" to identify all the
CC1_SPECs to change.
OK for the trunk,
Jeff
Anyway, does this also solve some of the issue Keith Packard was try to
nail down for picolibc?
next prev parent reply other threads:[~2022-11-20 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 13:02 Sebastian Huber
2022-07-22 13:02 ` [PATCH 2/2] RTEMS: Use local-exec TLS model by default Sebastian Huber
2022-07-22 14:02 ` [PATCH 1/2] Allow subtarget customization of CC1_SPEC Jose E. Marchesi
2022-07-25 5:59 ` Sebastian Huber
2022-07-25 6:06 ` Iain Sandoe
2022-08-04 13:02 ` Sebastian Huber
2022-09-08 5:33 ` Sebastian Huber
2022-10-04 9:47 ` Sebastian Huber
2022-10-26 9:34 ` Sebastian Huber
2022-11-20 16:57 ` Jeff Law [this message]
2022-11-21 7:26 ` Sebastian Huber
2022-11-21 14:58 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d880015-d502-a393-6278-4281cf64504b@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).