From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 2DE533858D39 for ; Thu, 23 Nov 2023 09:15:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DE533858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2DE533858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700730923; cv=none; b=d86xy4Y5RE3/uQyyl+zKpRaXitBtIEO5YY6Du3LpXmw9zebdf0UxNsrU9C9QNuhbAMSWs38O2q4cUKgRt+7kZ3HNpHroyo+nZdy+iyy9mDJtJiwPC3eu62gkfd1Jb9tpusu5m15JK029XELy+C8S7YvkCSQAJSgKlC1mWbeTFNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700730923; c=relaxed/simple; bh=FagVeacVA+qT1a2nG61e0Unme4smt+J8RgT+lpVWWP0=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=jPx5y5xulJlQZxuNzemMyeUWWYdAl1YS2oNe0Y3FIS5LQwy3fPxghoHTMOUPPhxpojj9IQ4o6t1WPwpePHvVCC4e6dnrdTa7iFV8VBykneeU2Cza3GCrOY84WcnG51ZlEyo4TDZnKb6gb4raN5hDLB+4TYZTzIrqXjrneJw+Tqo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r65nh-0000e5-4f for gcc-patches@gcc.gnu.org; Thu, 23 Nov 2023 04:15:20 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8CxrusWGF9lxjs8AA--.50950S3; Thu, 23 Nov 2023 17:15:02 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Cxzt4TGF9loIhKAA--.35567S3; Thu, 23 Nov 2023 17:15:00 +0800 (CST) Subject: Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20231120004728.205167-1-xry111@xry111.site> <20231120004728.205167-5-xry111@xry111.site> <7a4ceec5-2545-f30a-af44-7f7767620b76@loongson.cn> From: chenglulu Message-ID: <1d8a856e-d810-3bc9-b985-44c105802bf0@loongson.cn> Date: Thu, 23 Nov 2023 17:14:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Cxzt4TGF9loIhKAA--.35567S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7uFWrCF13Wr4UCF4ftw13Awc_yoW8tFy3p3 4kAF90kFWrZwn7G3WUt3s8X34aqr1UG3srWFWfWay8CanrXr1avr4xurn0gF1UW3yrJrWI vr1rK3W3ZFZ8AacCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9Sb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv 67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C2 67AKxVWUtVW8ZwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI 8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWU CwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r 1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBI daVFxhVjvjDU0xZFpf9x07jOb18UUUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-1.672,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/11/23 下午4:58, Xi Ruoyao 写道: > On Thu, 2023-11-23 at 16:23 +0800, chenglulu wrote: >> I tested it and it was fine. I never knew this could be used like >> this. > I remember when I wrote r13-3920 I tried this but failed. Maybe > something has been improved in machine description parser, or perhaps I > just did some stupid thing that time... But I think this is a really cool implementation! When I look at this code and compare it to our scalar implementation, it seems that our scalar implementation still lacks an "lround". > >> Thank you! >> >> 在 2023/11/20 上午8:47, Xi Ruoyao 写道: >>> No functional change, just a cleanup. >>> >>> gcc/ChangeLog: >>> >>> * config/loongarch/loongarch.md (lrint_allow_inexact): >>> Remove. >>> (2): Check if >>> == UNSPEC_FTINT instead of . >>> --- >>>   gcc/config/loongarch/loongarch.md | 5 +---- >>>   1 file changed, 1 insertion(+), 4 deletions(-) >>> >>> diff --git a/gcc/config/loongarch/loongarch.md >>> b/gcc/config/loongarch/loongarch.md >>> index 78ed63f2132..1e019815451 100644 >>> --- a/gcc/config/loongarch/loongarch.md >>> +++ b/gcc/config/loongarch/loongarch.md >>> @@ -585,9 +585,6 @@ (define_int_attr lrint_pattern [(UNSPEC_FTINT >>> "lrint") >>>   (define_int_attr lrint_submenmonic [(UNSPEC_FTINT "") >>>        (UNSPEC_FTINTRM "rm") >>>        (UNSPEC_FTINTRP "rp")]) >>> -(define_int_attr lrint_allow_inexact [(UNSPEC_FTINT "1") >>> -       (UNSPEC_FTINTRM "0") >>> -       (UNSPEC_FTINTRP "0")]) >>> >>>   ;; Iterator and attributes for bytepick.d >>>   (define_int_iterator bytepick_w_ashift_amount [8 16 24]) >>> @@ -2384,7 +2381,7 @@ (define_insn >>> "2" >>>    (unspec:ANYFI [(match_operand:ANYF 1 "register_operand" >>> "f")] >>>          LRINT))] >>>     "TARGET_HARD_FLOAT && >>> -   ( >>> +   ( == UNSPEC_FTINT >>>       || flag_fp_int_builtin_inexact >>>       || !flag_trapping_math)" >>>     "ftint.. %0,%1"