From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 39A823858D35 for ; Tue, 25 Apr 2023 09:10:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39A823858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682413804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ikeIUcLdX3+YQ8pCyzaFYgp80WVb8c+OH2YY+FjQark=; b=h24hYlCcr8NuDSIXkeBlNVd+sSENSZmfkDLNyEdbDvOmE1J4xTkmPAPk6dyMylt/+/xbsD OD2bKTB9l949VPUGEb9grSlaCNf0OP7gPq+03rGh2+JiwvxObWxVj5o2W+drSEpKBjZc6p XgJVY434itDC94LzqWVoB+KJAfckAvE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-2GODqG_xPQCSn5ZdRWKmeA-1; Tue, 25 Apr 2023 05:10:03 -0400 X-MC-Unique: 2GODqG_xPQCSn5ZdRWKmeA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-2ef39671038so1741325f8f.2 for ; Tue, 25 Apr 2023 02:10:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682413802; x=1685005802; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ikeIUcLdX3+YQ8pCyzaFYgp80WVb8c+OH2YY+FjQark=; b=BS2ckXcwAeeIjLLOUUUXy+7u84QaDfX5xMImUcTenGlFXNvDIasxEEIzbftkl7sdNs 6dDns3R/XlsGIGgRrfqXEFr9EDonC+lsDJIzXa42ymsBm7uWyHU9a44Zbo9spwZ6DFLI jOfdHnWxTAU0w7fFzeCdonAJbZ8MhtCXp/rsJbS8j2k+Uht0IaNafVaPTxAOE2pFxuZ2 jZXbBAOPS6px9IePs+RtccnQDIQornLdBikeNx247OdRWIK+OFyUuhC1Ws66eRoua5Mo w4XAQTreexaAFxLsaVdRkZAyAB+CASyE7As07Lzuhy9qAKLFPuLTIJPpPDGmQ1e4VnTy ReDQ== X-Gm-Message-State: AAQBX9fLW12eAMuQbVF9Ji2jywprd7DjrnC1zXBqWX+K9tTfKrfll0Al 8rMpvqfLeRfZjr6f405ew1eMt3e0xoGo0I5r0fA9mqD1g3XgHHl3qHaNC6USeB5Bck1mqYq06D8 BccQC5kh5hHgaOfjE6g== X-Received: by 2002:a5d:6690:0:b0:2fb:703d:1915 with SMTP id l16-20020a5d6690000000b002fb703d1915mr11675403wru.43.1682413802394; Tue, 25 Apr 2023 02:10:02 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIz2gviZ1a2J+5GUPMiGW4iZdTTCHtU5HbVw749cjYr65Kt7qXuDxqayK6VtHsjXnS+e4tMg== X-Received: by 2002:a5d:6690:0:b0:2fb:703d:1915 with SMTP id l16-20020a5d6690000000b002fb703d1915mr11675390wru.43.1682413802055; Tue, 25 Apr 2023 02:10:02 -0700 (PDT) Received: from [192.168.1.201] ([139.47.42.170]) by smtp.gmail.com with ESMTPSA id t12-20020a5d460c000000b002f6962ee703sm12618341wrq.61.2023.04.25.02.10.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 02:10:01 -0700 (PDT) Message-ID: <1d8e027e-1eae-f5b0-13a0-14e4d0aeed9b@redhat.com> Date: Tue, 25 Apr 2023 11:10:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Implement range-op entry for sin/cos. To: Mikael Morin , Jakub Jelinek , "Joseph S. Myers" , GCC patches , Andrew MacLeod References: <20230418131250.310916-1-aldyh@redhat.com> <4772e205-2123-1fa6-1cd6-8bd6ee22b439@orange.fr> From: Aldy Hernandez In-Reply-To: <4772e205-2123-1fa6-1cd6-8bd6ee22b439@orange.fr> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/21/23 22:43, Mikael Morin wrote: > Hello, > >> --- gcc/gimple-range-op.cc.jj    2023-04-21 17:09:48.250367999 +0200 >> +++ gcc/gimple-range-op.cc    2023-04-21 18:37:26.048325391 +0200 >> @@ -439,20 +436,38 @@ public: >>       r.set_varying (type); >>       return true; >>         } >> + >>       // Results outside of [-1.0, +1.0] are impossible. >>       REAL_VALUE_TYPE lb = lhs.lower_bound (); >>       REAL_VALUE_TYPE ub = lhs.upper_bound (); >> -    if (real_less (&lb, &dconstm1) >> -    || real_less (&dconst1, &ub)) >> +    if (real_less (&lb, &dconstm1) || real_less (&dconst1, &ub)) >>         { > > Shouldn't lb and ub be swapped in this condition? > If I understand correctly, we are looking for ranges like [whatever,x] > where x < -1.0 or [y, whatever] where 1.0 < y. > > Mikael > Thanks. Merged into the latest revision. Aldy