From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105864 invoked by alias); 29 Mar 2017 19:28:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105851 invoked by uid 89); 29 Mar 2017 19:28:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Mar 2017 19:28:28 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5A1C80F9E; Wed, 29 Mar 2017 19:28:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D5A1C80F9E Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D5A1C80F9E Received: from localhost.localdomain (ovpn-116-218.phx2.redhat.com [10.3.116.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id C0A8C189A0; Wed, 29 Mar 2017 19:28:26 +0000 (UTC) Subject: Re: C PATCH for c/79730, ICE on invalid with DECL_HARD_REGISTER To: Marek Polacek , GCC Patches , Joseph Myers References: <20170329180701.GT3172@redhat.com> From: Jeff Law Message-ID: <1dba621d-4177-7f6e-f63b-52549cc43ec0@redhat.com> Date: Wed, 29 Mar 2017 19:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170329180701.GT3172@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01486.txt.bz2 On 03/29/2017 12:07 PM, Marek Polacek wrote: > DECL_HARD_REGISTER only expects a VAR_DECL, so check for that first > (C++'s make_rtl_for_nonlocal_decl does that, too). > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > 2017-03-29 Marek Polacek > > PR c/79730 > * c-decl.c (finish_decl): Check VAR_P. > > * gcc.dg/pr79730.c: New test. OK. jeff