From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id B2E0D3858033 for ; Wed, 21 Jun 2023 12:54:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2E0D3858033 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3f9b4a71623so25578435e9.1 for ; Wed, 21 Jun 2023 05:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687352045; x=1689944045; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o0wZtQMxbih2FNSO9sflKr/mrJHQqJ5oHCkuWXhz9hQ=; b=HA2tPZLqklQFQ27JxnR4+dkspVxfQr611pI0nsGSbwF+8X76GY5CWhA/Mk7n+nBynF Dt6n+Jq7Teiz3MwLXspTXFsa7axe2z50Pk4Nviz148n5VwhzzANIIxpuycsxNowoyKBU 9U7Rua4vhh+RNOzy3Y3j7AUVLYHLE/z7BjUcxR+8Y956EOesu0APnngRSU6kQgE4gaPm a9kuhuAnlywAdU6BMiuxeNzCcgQ6Jd7HraA6GezI8/nkz0p+fkJx84gKxJqiAmXW0KtO FeNpbJ/PuN55s/M3BjQ0E1+qu0r1bJF/LxWcNXXbijBb1CRdiuSoCx/qfK/1lh432FV3 +Erg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687352045; x=1689944045; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o0wZtQMxbih2FNSO9sflKr/mrJHQqJ5oHCkuWXhz9hQ=; b=RcW5Jn4P0reDtKGfwYlzmLBNY1rQfrYTRIyCdMfw+EjnzL+1dwXnVZO4ujKY8W7EsJ upnyRtT4MXkpFInlfwOXcN4dhkFCyhxsx0B+lNef/RZ9R0/96PTe3sflvtsGudFYUtf3 crofhAdbI+11qhwqO8I5tfbwRhjGYn2zF4QQelbdYZDdEBWfMoiPaQlfDu4i3P53xpC3 zUVrEYCB1SpLG7ylius4bUIHO4xnhnKoqTMXqfntaVFIeLrHKxYFz8KWKdklKkaV+enP 4Qc7xfM304zIjIt8tt9vfUWfTjlp2I5wgFxrrvOdR3IGA+4Im1ynLCmlkb4qpPije/dm dzJQ== X-Gm-Message-State: AC+VfDwv3Aol3+yTs+EArZPQ5QJ3A5kK/isqwqTaWsbBtW7BqrYyKWsQ 9xJCAZr4hUp4RkR2TK3oxV0= X-Google-Smtp-Source: ACHHUZ6nSZcSc3JJu2aWyWlPZtq9KW7PZXRl6R+hnexfB+RfqrBL4FRrgXcUvqUmGyja4AWf+AFhJw== X-Received: by 2002:a5d:58c7:0:b0:30e:45ac:810e with SMTP id o7-20020a5d58c7000000b0030e45ac810emr11092244wrf.36.1687352045194; Wed, 21 Jun 2023 05:54:05 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id a17-20020a5d5711000000b003062b2c5255sm4402686wrv.40.2023.06.21.05.54.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 05:54:04 -0700 (PDT) Message-ID: <1ded312c-ed4c-4d45-93c2-da9aa28eca19@gmail.com> Date: Wed, 21 Jun 2023 14:54:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Support RVV floating-point ternary auto-vectorization Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20230621111252.236515-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20230621111252.236515-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Juzhe, LGTM apart from a tiny nit: > + /* We have a maximum of 11 operands for RVV instruction patterns according to > + * vector.md. */ > + insn_expander<11> e (/*OP_NUM*/ op_num, /*HAS_DEST_P*/ true, Seems like you copied this from the non-fp ternary part but the rest of the file uses RVV_INSN_OPERANDS_MAX already. Could you adjust this as well as emit_vlmax_ternary_insn? Thanks. Regards Robin