From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54562 invoked by alias); 22 Mar 2018 02:10:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54520 invoked by uid 89); 22 Mar 2018 02:10:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1114 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 02:10:44 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2M28q4n128238 for ; Wed, 21 Mar 2018 22:10:43 -0400 Received: from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gv0xuvx0s-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Wed, 21 Mar 2018 22:10:42 -0400 Received: from localhost by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Mar 2018 20:10:41 -0600 Received: from b03cxnp08025.gho.boulder.ibm.com (9.17.130.17) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 21 Mar 2018 20:10:40 -0600 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2M2Adu013697502; Wed, 21 Mar 2018 19:10:39 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7A31A6E040; Wed, 21 Mar 2018 20:10:39 -0600 (MDT) Received: from otta.local (unknown [9.85.154.167]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id A11C56E035; Wed, 21 Mar 2018 20:10:38 -0600 (MDT) Subject: Re: [PATCH, rs6000] Fix PR83789: __builtin_altivec_lvx fails for powerpc for altivec-4.c To: Segher Boessenkool Cc: GCC Patches , Kaushik Phatak , Bill Schmidt , Kelvin Nilsen References: <06a0a953-b8ec-f235-01b5-c0de8f4bb9e6@vnet.ibm.com> <20180312185503.GD21977@gate.crashing.org> <469daa3d-584f-62f9-da7d-db1c56638d04@vnet.ibm.com> <20180320164216.GK21977@gate.crashing.org> <8391763c-3f2a-db05-bdd2-93b41a8b29ed@vnet.ibm.com> <1f50b482-f4ac-6b0f-ea2d-8d3a19f836b0@vnet.ibm.com> <20180322003706.GS21977@gate.crashing.org> From: Peter Bergner Date: Thu, 22 Mar 2018 02:26:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322003706.GS21977@gate.crashing.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18032202-0024-0000-0000-0000181C8C7C X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008719; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000254; SDB=6.01006539; UDB=6.00512501; IPR=6.00785822; MB=3.00020172; MTD=3.00000008; XFM=3.00000015; UTC=2018-03-22 02:10:41 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18032202-0025-0000-0000-00004F32AEB4 Message-Id: <1e0c6a12-480e-a052-92dd-5c1041adb9b4@vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-22_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803220023 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg01152.txt.bz2 On 3/21/18 7:37 PM, Segher Boessenkool wrote: > On Wed, Mar 21, 2018 at 12:47:41PM -0500, Peter Bergner wrote: >> I'll note that GCC 7 does not need any of the changes to rs6000-p8swap.c, >> since that file doesn't exist and doesn't need to exist in GCC 7, so I've >> left those changes out. > > Did that same code live in rs6000.c in GCC 7, or is it new since > rs6000-p8swap.c was split off from there? And what about GCC 6? The trunk patch's changes to rs6000-p8swap.c were to rs6000_gen_lvx and rs6000_gen_stvx and those are new to GCC 8. They are used as part of Kelvin's optimization that changes the little endian unfriendly vsx loads and stores that require swaps, with the altivec lvx/stvx which do not need swaps. That optimization was new to GCC 8, so there was no need for the rs6000-p8swap.c changes. If you're asking about whether we also need to backport to GCC 6, I believe Kaushik said in the bugzilla that he only encountered the ICE on GCC 7 and trunk, so I don't think we need a GCC 6 backport. Peter