From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 02A673858D32 for ; Thu, 7 Jul 2022 12:07:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 02A673858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxj9JjzMZiNBwPAA--.2605S2; Thu, 07 Jul 2022 20:06:59 +0800 (CST) Subject: Re: [PATCH v3] LoongArch: Modify fp_sp_offset and gp_sp_offset's calculation method when frame->mask or frame->fmask is zero. To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20220707103050.2849360-1-chenglulu@loongson.cn> <9ef83ca077557a038cc0d774352303e910e8fee1.camel@xry111.site> From: Lulu Cheng Message-ID: <1e1a11f6-64b5-1ec3-c069-f8a52fd41f18@loongson.cn> Date: Thu, 7 Jul 2022 20:06:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9ef83ca077557a038cc0d774352303e910e8fee1.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf9Dxj9JjzMZiNBwPAA--.2605S2 X-Coremail-Antispam: 1UD129KBjvdXoW7JFy7Zw1DJw18Jr1UWF4Uurg_yoW3uFXE9F 1xCr1vkw4Ut3WkJFn0vFyDAFZxGF4DuryfKa4DXrs7GryDJ3Z8Ar4kGaykAF1j9wn8Xrna 9rWfJFyIyr909jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7Mxk0xIA0c2IEe2xFo4CEbIxv r21lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I 0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWU AVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcV CY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjfU5WlkUUUUU X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SCC_BODY_URI_ONLY, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 12:07:09 -0000 在 2022/7/7 下午7:51, Xi Ruoyao 写道: > On Thu, 2022-07-07 at 18:30 +0800, Lulu Cheng wrote: > > /* snip */ > > >> diff --git a/gcc/testsuite/gcc.target/loongarch/prolog-opt.c >> b/gcc/testsuite/gcc.target/loongarch/prolog-opt.c >> new file mode 100644 >> index 00000000000..c7bd71dde93 >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/loongarch/prolog-opt.c >> @@ -0,0 +1,15 @@ >> +/* Test that LoongArch backend stack drop operation optimized.  */ >> + >> +/* { dg-do compile } */ >> +/* { dg-options "-O2 -mabi=lp64d" } */ >> +/* { dg-final { scan-assembler "addi.d\t\\\$r3,\\\$r3,-16" } } */ >> + >> +#include > It's better to hard code "extern int printf(char *, ...);" here, so the > test case won't unnecessarily depend on libc header. > > LGTM otherwise. > OK! Thanks!:-)