From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xry111@mengyan1223.wang>
Received: from mengyan1223.wang (mengyan1223.wang [89.208.246.23])
 by sourceware.org (Postfix) with ESMTPS id 0AE673857820
 for <gcc-patches@gcc.gnu.org>; Mon, 30 Aug 2021 06:52:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0AE673857820
Received: from [IPv6:240e:35a:10e9:a200:dc73:854d:832e:2] (unknown
 [IPv6:240e:35a:10e9:a200:dc73:854d:832e:2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest
 SHA384) (Client did not present a certificate)
 (Authenticated sender: xry111@mengyan1223.wang)
 by mengyan1223.wang (Postfix) with ESMTPSA id C03876597C;
 Mon, 30 Aug 2021 02:52:24 -0400 (EDT)
Message-ID: <1e3890c74d5c76b94d7e130bb4fbd18e8583a2ba.camel@mengyan1223.wang>
Subject: Re: [PATCH v2 1/2] MIPS: use mips_isa enum instead hardcoded numbers
From: Xi Ruoyao <xry111@mengyan1223.wang>
To: YunQiang Su <yunqiang.su@cipunited.com>, gcc-patches@gcc.gnu.org
Date: Mon, 30 Aug 2021 14:52:16 +0800
In-Reply-To: <20210830025932.297055-1-yunqiang.su@cipunited.com>
References: <20210830025932.297055-1-yunqiang.su@cipunited.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Aug 2021 06:52:39 -0000

These two patches look good to me.  Still, need a maintainer's approval.

On Sun, 2021-08-29 at 22:59 -0400, YunQiang Su wrote:
> Currently mips-cpu.defs, mips.h, netbsd.h and config.gcc are
> using hardcoded numbers for isa level.
> 
> Let's replace them with more readable enum mips_isa.
> 
> gcc/ChangeLog:
>         * config/mips/mips.h (struct mips_cpu_info): define enum mips_isa;
>           use enum instead of int for 'isa' member.
>         * config/config.gcc, config/mips/mips{.h,-cpus.def},
>           config/mips/netbsd.h: replace hardcoded numbers with enum.
> ---
>  gcc/config.gcc                |  62 ++++-----
>  gcc/config/mips/mips-cpus.def | 228 +++++++++++++++++-----------------
>  gcc/config/mips/mips.c        |   5 +-
>  gcc/config/mips/mips.h        |  84 ++++++++-----
>  gcc/config/mips/netbsd.h      |   5 +-
>  5 files changed, 203 insertions(+), 181 deletions(-)