From: Alexander Monakov <amonakov@ispras.ru>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Tom de Vries <tdevries@suse.de>,
Tobias Burnus <tobias@codesourcery.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libgomp, nvptx, v3: Honor OpenMP 5.1 num_teams lower bound
Date: Sat, 13 Nov 2021 00:08:48 +0300 (MSK) [thread overview]
Message-ID: <1e76e918-1668-fd6e-9ffb-4da71e931f2d@ispras.ru> (raw)
In-Reply-To: <20211112175804.GJ2710@tucnak>
On Fri, 12 Nov 2021, Jakub Jelinek via Gcc-patches wrote:
> --- libgomp/config/nvptx/team.c.jj 2021-05-25 13:43:02.793121350 +0200
> +++ libgomp/config/nvptx/team.c 2021-11-12 17:49:02.847341650 +0100
> @@ -32,6 +32,7 @@
> #include <string.h>
>
> struct gomp_thread *nvptx_thrs __attribute__((shared,nocommon));
> +int __gomp_team_num __attribute__((shared));
It's going to be weird to have two declarations next to each other, one with
'nocommon', one without. Could you have 'nocommon' also on the new one, and
then, if you like, to add extern declarations for both variables and drop the
attribute (in a separate patch)?
Alexander
prev parent reply other threads:[~2021-11-12 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 13:20 [PATCH] libgomp, nvptx: " Jakub Jelinek
2021-11-12 13:27 ` [PATCH] libgomp, nvptx, v2: " Jakub Jelinek
2021-11-12 17:58 ` [PATCH] libgomp, nvptx, v3: " Jakub Jelinek
2021-11-12 19:16 ` Alexander Monakov
2021-11-12 19:47 ` Jakub Jelinek
2021-11-12 19:49 ` Jakub Jelinek
2021-11-12 21:21 ` Alexander Monakov
2021-11-12 21:08 ` Alexander Monakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e76e918-1668-fd6e-9ffb-4da71e931f2d@ispras.ru \
--to=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=tdevries@suse.de \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).