[committed] avoid pedantic warning in C++ 98 mode: comma at end of enumerator list

[committed] avoid pedantic warning in C++ 98 mode: comma at end of enumerator list

[Martin Sebor]

I removed the trailing comma and (after a few false starts) managed
to push the change in commit
   r10-6466-g297aa668293d55ffe100d810e92fbe592f262557.

I got the error below for my first few attempts.  The message had
the expected format so I wasn't sure what the problem was until
I removed the "[-Wpedantic]" part at the end.  Was it looking for
a bug id and getting confused?

Martin

remote: *** Invalid revision history for commit 
1475ba69fd77b6c22b10e76ad94fa487d931dabd:
remote: *** The first line should be the subject of the commit,
remote: *** followed by an empty line.
remote: ***
remote: *** Below are the first few lines of the revision history:
remote: *** | Remove trailing comma to avoid pedantic warning in C++ 98 
mode:
remote: *** |   comma at end of enumerator list [-Wpedantic]
remote: ***
remote: *** Please amend the commit's revision history and try again.
remote: error: hook declined to update refs/heads/master

Re: [committed] avoid pedantic warning in C++ 98 mode: comma at end of enumerator list

[Joseph Myers]

On Wed, 5 Feb 2020, Martin Sebor wrote:

> I removed the trailing comma and (after a few false starts) managed
> to push the change in commit
>   r10-6466-g297aa668293d55ffe100d810e92fbe592f262557.
> 
> I got the error below for my first few attempts.  The message had
> the expected format so I wasn't sure what the problem was until
> I removed the "[-Wpedantic]" part at the end.  Was it looking for
> a bug id and getting confused?

No, this error looks like there not being a blank line after the first 
line of the original commit message (a single-line commit message like you 
ended up with is OK for simple commits where a single line is sufficient 
description, but if there's more then one line there must be a blank line 
after the first line, which should act as a self-contained summary for 
tools such as "git log --oneline" to work well).

> remote: *** Below are the first few lines of the revision history:
> remote: *** | Remove trailing comma to avoid pedantic warning in C++ 98 mode:
> remote: *** |   comma at end of enumerator list [-Wpedantic]

-- 
Joseph S. Myers
joseph@codesourcery.com