From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106007 invoked by alias); 6 Feb 2020 00:29:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 105995 invoked by uid 89); 6 Feb 2020 00:29:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=declined, HX-Languages-Length:1016 X-HELO: mail-qt1-f170.google.com Received: from mail-qt1-f170.google.com (HELO mail-qt1-f170.google.com) (209.85.160.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Feb 2020 00:29:34 +0000 Received: by mail-qt1-f170.google.com with SMTP id v25so3148611qto.7 for ; Wed, 05 Feb 2020 16:29:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=Oqmdk8ySvKd+9BpEhC54rRy6n24oihsSFwBqJAmwTvU=; b=AY148VRRZlRCI2IsGp+Q6IBYRHDGeUTiGlAt7i7Yx/cVaeaWKFcviLBVDQVHcdGs/9 ceQdCQ5gVTI2kirIfcOxakyI7hPijzGKvOLZBVnhKnHn3CcGY++EH8YkToLQ8q58EI2l OUC1JsMWtLdy4Eyz7KpvmS8d0ZBl4/yNzY1L1ghBhRCfjSflu07UcaHBXZIjoJOOmx1e XY2ZQfMDYChLcfsRSqT5mqVE+JITsMfffpCUE9ejDXYv7mlLI42QaO8u6rbKgGZ1K4ql IvEqW29Y8I8Ha4x9prKSK4/FUh0GSZy8GMwWdB5BeW7OR8Kj54ddEm9gJ274SZmlomjw KhmA== Return-Path: Received: from [192.168.0.41] (174-16-112-158.hlrn.qwest.net. [174.16.112.158]) by smtp.gmail.com with ESMTPSA id 205sm648449qkd.61.2020.02.05.16.29.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Feb 2020 16:29:32 -0800 (PST) To: gcc-patches From: Martin Sebor Subject: [committed] avoid pedantic warning in C++ 98 mode: comma at end of enumerator list Message-ID: <1e9eabaf-001d-8c28-684c-6322b929f1eb@gmail.com> Date: Thu, 06 Feb 2020 00:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00312.txt.bz2 I removed the trailing comma and (after a few false starts) managed to push the change in commit r10-6466-g297aa668293d55ffe100d810e92fbe592f262557. I got the error below for my first few attempts. The message had the expected format so I wasn't sure what the problem was until I removed the "[-Wpedantic]" part at the end. Was it looking for a bug id and getting confused? Martin remote: *** Invalid revision history for commit 1475ba69fd77b6c22b10e76ad94fa487d931dabd: remote: *** The first line should be the subject of the commit, remote: *** followed by an empty line. remote: *** remote: *** Below are the first few lines of the revision history: remote: *** | Remove trailing comma to avoid pedantic warning in C++ 98 mode: remote: *** | comma at end of enumerator list [-Wpedantic] remote: *** remote: *** Please amend the commit's revision history and try again. remote: error: hook declined to update refs/heads/master