From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <rguenther@suse.de>, Jakub Jelinek <jakub@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: Patch ping Re: [PATCH] i386: Fix up ix86_gimplify_va_arg [PR105331]
Date: Thu, 28 Apr 2022 07:16:18 -0600 [thread overview]
Message-ID: <1edab0e4-d797-f38b-56ee-4d27acb53748@gmail.com> (raw)
In-Reply-To: <4451q2s-551p-5p97-6n5p-353r49op73p3@fhfr.qr>
On 4/28/2022 4:31 AM, Richard Biener wrote:
> On Thu, 28 Apr 2022, Jakub Jelinek wrote:
>
>> On Thu, Apr 28, 2022 at 10:39:39AM +0200, Uros Bizjak wrote:
>>>>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>>>>>
>>>>> 2022-04-22 Jakub Jelinek <jakub@redhat.com>
>>>>>
>>>>> PR target/105331
>>>>> * config/i386/i386.cc (ix86_gimplify_va_arg): Mark va_arg_tmp
>>>>> temporary TREE_ADDRESSABLE before trying to gimplify ADDR_EXPR
>>>>> of it.
>>>>>
>>>>> * gcc.dg/pr105331.c: New test.
>>> Sorry, I have no idea if this patch is correct or not.
>> Richard or Jeff, could you please review it instead?
> OK.
Agreed. In fact I'd fixed something very similar in our port a while ago.
Jeff
prev parent reply other threads:[~2022-04-28 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:25 Jakub Jelinek
2022-04-28 8:31 ` Patch ping " Jakub Jelinek
2022-04-28 8:39 ` Uros Bizjak
2022-04-28 10:30 ` Jakub Jelinek
2022-04-28 10:31 ` Richard Biener
2022-04-28 13:16 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1edab0e4-d797-f38b-56ee-4d27acb53748@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).