From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 520EA3858405 for ; Thu, 28 Apr 2022 13:16:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 520EA3858405 Received: by mail-pg1-x534.google.com with SMTP id 7so76757pga.12 for ; Thu, 28 Apr 2022 06:16:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+hVs4E8nXOgX3Ky6uR/h8jAS1/R2rmy32QKKPcwIGNI=; b=Pz9ZeY2BE728Fb3htJKdOQKN2ehFVEtk/HrWv7aumSNXY5asFKs4628HPj7NFMwviZ V3pnQdI/gyasyNq5+YfTml3D4IVZXvAWw4OwlDTvy4L9+WHlUtvZGp5mMikizSIiFGu+ mao1YLvzzEiz2oxN5mer209PsuyhKX2V7VZU1o9kppUBv6guOthJGLZV93HkJF3W+amR 7Fs5fKRkrss5RIdJz8odQoIvjI29CYpihPZ5/WmJsNCXQCyQkoMMAA/sW9KUhKaO2Ptr kcoGRddiqexBWbTT9cj/Uc05A3YoX+bH90wBr9IALQwlLoX2iqe7lqOFj13I5RO2scur uLjg== X-Gm-Message-State: AOAM530X3X+pEpdqfWUu+GdHzvHXdoszpDfxcGks4SlttOXX3TQpmDTj nDFv9joMUk2CwEBdvHYYdZI= X-Google-Smtp-Source: ABdhPJxCKGbxoL3H/p8wPr/vzHTJc1WWeexAE+srutntp28XZRU2ZqMGA0OeVF1zlcAdP3HY5Brx1g== X-Received: by 2002:a63:79ce:0:b0:3a9:efa0:17d with SMTP id u197-20020a6379ce000000b003a9efa0017dmr28363061pgc.170.1651151780765; Thu, 28 Apr 2022 06:16:20 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id i23-20020a056a00225700b0050d38d0f58dsm15473165pfu.213.2022.04.28.06.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 06:16:20 -0700 (PDT) Message-ID: <1edab0e4-d797-f38b-56ee-4d27acb53748@gmail.com> Date: Thu, 28 Apr 2022 07:16:18 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: Patch ping Re: [PATCH] i386: Fix up ix86_gimplify_va_arg [PR105331] Content-Language: en-US To: Richard Biener , Jakub Jelinek Cc: "gcc-patches@gcc.gnu.org" References: <4451q2s-551p-5p97-6n5p-353r49op73p3@fhfr.qr> From: Jeff Law In-Reply-To: <4451q2s-551p-5p97-6n5p-353r49op73p3@fhfr.qr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2022 13:16:23 -0000 On 4/28/2022 4:31 AM, Richard Biener wrote: > On Thu, 28 Apr 2022, Jakub Jelinek wrote: > >> On Thu, Apr 28, 2022 at 10:39:39AM +0200, Uros Bizjak wrote: >>>>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? >>>>> >>>>> 2022-04-22 Jakub Jelinek >>>>> >>>>> PR target/105331 >>>>> * config/i386/i386.cc (ix86_gimplify_va_arg): Mark va_arg_tmp >>>>> temporary TREE_ADDRESSABLE before trying to gimplify ADDR_EXPR >>>>> of it. >>>>> >>>>> * gcc.dg/pr105331.c: New test. >>> Sorry, I have no idea if this patch is correct or not. >> Richard or Jeff, could you please review it instead? > OK. Agreed.  In fact I'd fixed something very similar in our port a while ago. Jeff