From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 38BEF384F4A9 for ; Wed, 7 Dec 2022 05:51:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38BEF384F4A9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B75Mq3B031469; Wed, 7 Dec 2022 05:51:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=n3lpjlCSJCn6UbHI5nIcv0hDI+EYIWNFBB64ZThUpig=; b=pTVm+1y8jrYN6mx2NguMXChH9OY2Sd4xM+KlmKUIkLrqDJNvUWZjlVwCqI8tYqD2jB6d mRyHSCPUVnaXAAdg34YKP5Fjbh07gf58QpgkK0pY5+yT+m0aQ49jn6qXBO1yvJaB1bBX ytsVQJ8x3tAaRVhzmFjdWBX0wBPaRnYOmxdSUz2sfJb9AqksL7cSTvCifo5e09t5zkdP qzVrWi5hIdsNtKUMkWz8BKnNAhUP/cSp31CWzBcjooJU+p7AAy8heOvCSyHMEps0/IFn 281q2FMhGEIcyByEfbephbTSjRvKIJVnDQf9Bmn+UmLlR1Yj3Np5i02B4VFZZPE486FH 9Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3mamms0hwn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Dec 2022 05:51:01 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B75lM81028593; Wed, 7 Dec 2022 05:51:00 GMT Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3mamms0hw4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Dec 2022 05:51:00 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2B6DYaIo002987; Wed, 7 Dec 2022 05:50:59 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma04fra.de.ibm.com (PPS) with ESMTPS id 3m9kur1s2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Dec 2022 05:50:58 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B75ot3p41615618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Dec 2022 05:50:55 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4863320043; Wed, 7 Dec 2022 05:50:55 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A73920040; Wed, 7 Dec 2022 05:50:53 +0000 (GMT) Received: from [9.197.224.206] (unknown [9.197.224.206]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 7 Dec 2022 05:50:52 +0000 (GMT) Message-ID: <1efd32eb-cef4-897d-bb71-b3763bf733bd@linux.ibm.com> Date: Wed, 7 Dec 2022 13:50:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3, rs6000] Enable have_cbranchcc4 on rs6000 Content-Language: en-US To: HAO CHEN GUI Cc: Segher Boessenkool , David , Peter Bergner , gcc-patches , Richard Biener References: <83b3cb82-e054-8793-8cf5-232a3262ff02@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <83b3cb82-e054-8793-8cf5-232a3262ff02@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 9RbZlXEAQ7wBiefnZ4VM3s-HLyF0a2rr X-Proofpoint-ORIG-GUID: jmafpRhMFP0l8TW0hNhcHLdUQQpOsafW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-07_02,2022-12-06_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 mlxscore=0 clxscore=1015 phishscore=0 mlxlogscore=827 bulkscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212070043 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2022/12/7 13:24, HAO CHEN GUI wrote: > Hi Kewen, > Thanks so much for your review comments. I will fix them. > > 在 2022/12/7 11:06, Kewen.Lin 写道: >> Does this issue which relies on the fix for generic part make bootstrapping fail? >> If no, how many failures it can cause? I'm thinking if we can commit this firstly, >> then in the commit log of the fix for generic part you can mention it can fix the >> ICE exposed by this test case. > > Yes, the bootstrapping fails if we enable cbranchcc4 without the generic patch. > Actually, the testcase comes from the ICE found in bootstrapping. Ah, thanks for confirming, so the fix for the generic part should come first. I just noticed Richi has approved it, you can mention this test case gcc.target/powerpc/cbranchcc4-1.c in the commit log for a record when committing it. Thanks! BR, Kewen