From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.rbg.tum.de (mailout1.rbg.tum.de [IPv6:2a09:80c0::201]) by sourceware.org (Postfix) with ESMTPS id 2D4F7385842E for ; Tue, 2 May 2023 14:32:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D4F7385842E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=in.tum.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=in.tum.de Received: from mailrelay1.rbg.tum.de (mailrelay1.in.tum.de [IPv6:2a09:80c0:254::14]) by mailout1.rbg.tum.de (Postfix) with ESMTPS id 27C8C71; Tue, 2 May 2023 16:32:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=in.tum.de; s=20220209; t=1683037927; bh=aeT2DD26WgmKbxX9HFAL0lEZCWSMmmmllb0CRV9gYYU=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=pCk1wWgEaxnKh1f4Zp0UiBfUe16kvZ9cVjqaCwJ61SwsdWAJNKNUFIeIcVFuhHu9Z bsCetS4rDIWhY/xoeCZvF0stqLIUuuwrXTdtpALHGBvk+xM368iOs0vUDVXtZcapGa +vDQvqtxSNPnz2x4rn9DhWIvIypPAq7l5t8tJz5BCMTevF2cuIAZO++4DBdWe5t6op pDJD5uRj9By2wkCg4kVKYN+ET0thuQ1S+FrkcjAyqygCjhsVUrNhrfS4DvR/uuWMsU 0VhiaKAwV7nZ3nSUzPoUXv+Myf1Ajqf8MBck9cJoTKvtwvfggp1tyky//6JOeO2gvE +m9U+LlI5Muuw== Received: by mailrelay1.rbg.tum.de (Postfix, from userid 112) id 1F30F1A4; Tue, 2 May 2023 16:32:07 +0200 (CEST) Received: from mailrelay1.rbg.tum.de (localhost [127.0.0.1]) by mailrelay1.rbg.tum.de (Postfix) with ESMTP id C108D1A1; Tue, 2 May 2023 16:32:06 +0200 (CEST) Received: from mail.in.tum.de (vmrbg426.in.tum.de [131.159.0.73]) by mailrelay1.rbg.tum.de (Postfix) with ESMTPS id BC54E1A0; Tue, 2 May 2023 16:32:06 +0200 (CEST) Received: by mail.in.tum.de (Postfix, from userid 112) id B4F274A0217; Tue, 2 May 2023 16:32:06 +0200 (CEST) Received: (Authenticated sender: neumann) by mail.in.tum.de (Postfix) with ESMTPSA id 4B6894A01F2; Tue, 2 May 2023 16:32:06 +0200 (CEST) (Extended-Queue-bit xtech_th@fff.in.tum.de) Message-ID: <1f18e946-c88f-f5dc-92d3-6b7171fcc626@in.tum.de> Date: Tue, 2 May 2023 16:32:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Thomas Neumann Subject: [PATCH] release the sorted FDE array when deregistering a frame [PR109685] To: "gcc-patches@gcc.gnu.org" Cc: Jakub Jelinek , markus.boeck02@gmail.com References: <2a4776b9-9271-bb3c-a626-d5ec22dae6f3@in.tum.de> <91045a34-a534-4436-bb06-cac32d797a36@in.tum.de> <87sfibqu1s.fsf@oldenburg.str.redhat.com> Content-Language: en-US In-Reply-To: <87sfibqu1s.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The atomic fastpath bypasses the code that releases the sort array which was lazily allocated during unwinding. We now check after deregistering if there is an array to free. libgcc/ChangeLog: * unwind-dw2-fde.c: Free sort array in atomic fast path. --- libgcc/unwind-dw2-fde.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libgcc/unwind-dw2-fde.c b/libgcc/unwind-dw2-fde.c index 7b74c391ced..4d2737ff9f7 100644 --- a/libgcc/unwind-dw2-fde.c +++ b/libgcc/unwind-dw2-fde.c @@ -240,6 +240,12 @@ __deregister_frame_info_bases (const void *begin) // And remove ob = btree_remove (®istered_frames, range[0]); + + // Deallocate the sort array if any. + if (ob && ob->s.b.sorted) + { + free (ob->u.sort); + } #else init_object_mutex_once (); __gthread_mutex_lock (&object_mutex); -- 2.39.2