From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44556 invoked by alias); 18 Aug 2018 04:13:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44510 invoked by uid 89); 18 Aug 2018 04:13:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Aug 2018 04:13:44 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 317DE85362; Sat, 18 Aug 2018 04:13:43 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-9.rdu2.redhat.com [10.10.112.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30D555FCA9; Sat, 18 Aug 2018 04:13:40 +0000 (UTC) Subject: Re: [PATCH] convert braced initializers to strings (PR 71625) To: Bernd Edlinger , Martin Sebor , "Joseph S. Myers" Cc: James Greenhalgh , Jason Merrill , GCC Patches , "nd@arm.com" References: From: Jeff Law Openpgp: preference=signencrypt Message-ID: <1f3928f7-2c01-e8a3-699f-ae035548c37f@redhat.com> Date: Sat, 18 Aug 2018 04:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg01082.txt.bz2 On 08/17/2018 04:26 PM, Bernd Edlinger wrote: > Hi everybody, > > On 08/16/18 08:36, Bernd Edlinger wrote: >> Jeff Law wrote: >>> I wonder if the change to how we set up the initializers is ultimately >>> changing the section those go into and ultimately causing an overflow of >>> the .sdata section. >> >> >> Yes, that is definitely the case. >> Due to the -fmerge-all-constants option used >> named arrays with brace initializer look like string initializers >> and can go into the merge section if there are no embedded nul chars. >> But the string constants can now be huge. >> >> See my other patch about string merging: >> [PATCH] Handle not explicitly zero terminated strings in merge sections >> https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00481.html >> >> >> Can this section overflow? >> > > > could someone try out if this (untested) patch fixes the issue? It seems to in my limited testing. jeff