From: "Kewen.Lin" <linkw@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] i386: Disable param ira-consider-dup-in-all-alts [PR100328]
Date: Fri, 2 Jul 2021 10:28:22 +0800 [thread overview]
Message-ID: <1f49b5b4-51a0-2695-c797-233d3ffe73c0@linux.ibm.com> (raw)
In-Reply-To: <0f75aadc-c389-ad37-3383-3be5b093c3e5@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
Hi,
With Hongtao's help (thanks), we got the SPEC2017 performance
evaluation result on x86_64 (see [1]), this new parameter
ira-consider-dup-in-all-alts has negative effects on i386.
Since we observed it can benefit ports aarch64 and rs6000, the
param is set as 1 by default, this patch is to disable it on
i386 explicitly to avoid performance degradation there.
Bootstrapped & regtested on x86_64-redhat-linux.
Is it ok for trunk?
BR,
Kewen
[1] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573986.html
-----
[-- Attachment #2: 0002-i386-Disable-param-ira-consider-dup-in-all-alts-PR10.patch --]
[-- Type: text/plain, Size: 1255 bytes --]
From 457c7b3032e20ea0f9d8c8d2980e7da6daeedb13 Mon Sep 17 00:00:00 2001
From: Kewen Lin <linkw@linux.ibm.com>
Date: Mon, 21 Jun 2021 22:51:09 -0500
Subject: [PATCH 2/2] i386: Disable param ira-consider-dup-in-all-alts
[PR100328]
With Hongtao's SPEC2017 performance evaluation result here:
https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573986.html
this new parameter ira-consider-dup-in-all-alts has negative
effects on i386, this patch is to disable it explicitly on
i386.
Bootstrapped & regtested on x86_64-redhat-linux.
gcc/ChangeLog:
PR rtl-optimization/100328
* config/i386/i386-options.c (ix86_option_override_internal):
Set param_ira_consider_dup_in_all_alts to 0.
---
gcc/config/i386/i386-options.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c
index 0eccb549c22..7a35c468da3 100644
--- a/gcc/config/i386/i386-options.c
+++ b/gcc/config/i386/i386-options.c
@@ -2831,6 +2831,8 @@ ix86_option_override_internal (bool main_args_p,
if (ix86_indirect_branch != indirect_branch_keep)
SET_OPTION_IF_UNSET (opts, opts_set, flag_jump_tables, 0);
+ SET_OPTION_IF_UNSET (opts, opts_set, param_ira_consider_dup_in_all_alts, 0);
+
return true;
}
--
2.17.1
next prev parent reply other threads:[~2021-07-02 2:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 5:18 [RFC/PATCH] ira: Consider matching constraints with param [PR100328] Kewen.Lin
2021-06-28 6:26 ` [RFC/PATCH v3] ira: Support more matching constraint forms " Kewen.Lin
2021-06-28 7:12 ` Hongtao Liu
2021-06-28 7:20 ` Hongtao Liu
2021-06-28 7:27 ` Kewen.Lin
2021-06-30 8:53 ` Hongtao Liu
2021-06-30 9:42 ` Kewen.Lin
2021-06-30 10:18 ` Hongtao Liu
2021-06-30 15:42 ` Richard Sandiford
2021-07-02 2:18 ` Kewen.Lin
2021-06-30 15:24 ` Vladimir Makarov
2021-07-02 2:11 ` [PATCH v4] " Kewen.Lin
2021-07-02 2:28 ` Kewen.Lin [this message]
2021-07-02 8:05 ` [PATCH] i386: Disable param ira-consider-dup-in-all-alts [PR100328] Uros Bizjak
2021-07-05 13:04 ` [PATCH v4] ira: Support more matching constraint forms with param [PR100328] Vladimir Makarov
2021-06-30 15:25 ` [RFC/PATCH v3] " Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f49b5b4-51a0-2695-c797-233d3ffe73c0@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).