From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id D384A3853D50 for ; Mon, 21 Nov 2022 14:27:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D384A3853D50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x533.google.com with SMTP id f9so7099358pgf.7 for ; Mon, 21 Nov 2022 06:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LoPu+eGumZAAa+lbZkB5M3gJO06uVXBXsBTiJDiZqYY=; b=F5N1QQssyJt0Eqyj6XcN7bYob2Kt+Cg4s92j9pHthkFnhXJjyNkGeD8sAbmUxw4XLr xUhFqBKGbKZBrwenHH49E8K1xr7njgxHMVUZ5kNhHvnKrT0Bbs+FK0UQmlkeA0sLihn/ Or5SqmS5QzS575gcClMV4+7uXZa3Onj4In+7Y9NALYjFDBrkbYLfSOvHNKxg9KkcSsWq lVHEWkrMGDnez2cCmLcg5FSmmVRoTI1iuEUA3TP9l3uhJZZdvQCrAq4iTgTlfhKLZD4s Xk6YjWv25wwITLro8OjdrMHQZMauKtXXcvNoU62xmQDaVbOlWYOL6yE4Q1xnLbPBG921 rsSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LoPu+eGumZAAa+lbZkB5M3gJO06uVXBXsBTiJDiZqYY=; b=GFBavAFXcDt+fHTdPpBwBPfedBSauEnowRk+jrBbCHUxL4GmNN8O5o3uFKiSJh2fL8 DfCAacO2PpNK4qktyXPBE49zCGPTrr6GPPyKx227f/bRGekdejth0BGf2I06xkUvLSxG +Q6g4+PZ721etCQLjHSlNSy0GbyVpRqq+vPoIaE2XraToUQFicyaTCMSCap9bDoBBfgk h7J+3PSDJMcbgp+UqXQmVH0nmGFMJBc1i5CB0LCOjwYeqjYDEHmSNcpqew+mO5DKcVai nVYEWboZJ9/1JnKVg/Jk7oGl0HOzHV03575GSlA2ZPIMilrbD5o0aLDkCkn1ShXBTH3p SYkA== X-Gm-Message-State: ANoB5plOkonMOgXtiVNCtRi9sw1watw8ktBRiN4zUW5iKj36u57pBFud 0aUZ6vHnqEGEAfPZw3kIqv4= X-Google-Smtp-Source: AA0mqf7Sdz14ZryXxUM3mKqOsv0fTOgBLKOKZFPjETTghDgcBV2HHVloU/EPDFglPQT1ZBzt3d+3Iw== X-Received: by 2002:a63:d556:0:b0:435:7957:559d with SMTP id v22-20020a63d556000000b004357957559dmr7049320pgi.122.1669040851704; Mon, 21 Nov 2022 06:27:31 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d4-20020a170902cec400b001885dbe31dfsm9958627plg.178.2022.11.21.06.27.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 06:27:30 -0800 (PST) Message-ID: <1f7f651c-4079-d392-a94f-2ba4591a2324@gmail.com> Date: Mon, 21 Nov 2022 07:27:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] genmultilib: Fix sanity check Content-Language: en-US To: Christophe Lyon , Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20221121115915.374247-1-christophe.lyon@arm.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/22 05:20, Christophe Lyon via Gcc-patches wrote: > > > On 11/21/22 13:17, Jakub Jelinek wrote: >> On Mon, Nov 21, 2022 at 12:59:15PM +0100, Christophe Lyon wrote: >>> My previous patch to add a sanity check to genmultilib actually >>> checked the number of dirnames with the number of "sets of options" >>> rather than the number of options, thus breaking the build on some >>> targets. >>> >>> To avoid duplicating once more the loop that constructs the sed >>> patterns, this patch checks that the current dirname/osdirname is not >>> empty in the existing loops. >>> >>> Are there targets where: >>> if [ "$1" != "${opt}" ]; then >>> is "legally" executed with an empty $1? (and thus where this patch >>> would incorrectly trigger an error?) >> >> Dunno, let's try your patch.  And if that triggers on something >> valid then the next step would be just to revert the sanity checks >> completely. > > Agreed. The first version (as we know) tripped on a few targets in my tester.  I've got those restarted and we should know in a few hours if there's any major issues. jeff