public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Arnaud Charlet <charlet@adacore.com>
Cc: gcc-patches@gcc.gnu.org,
	Pierre-Marie de Rodat <derodat@adacore.com>,
	Marc Poulhies <poulhies@adacore.com>
Subject: Re: [PATCH] doc: Ada: include Indices and Tables in manuals
Date: Mon, 14 Nov 2022 09:20:23 +0100	[thread overview]
Message-ID: <1fa2877d-03d4-d753-9a6c-2312d6f80952@suse.cz> (raw)
In-Reply-To: <20221114073235.GA1718056@adacore.com>

On 11/14/22 08:32, Arnaud Charlet wrote:
>>>>>> Sorry for the breakage. However, I contacted you (and your colleague) and haven't received
>>>>>> any feedback for a couple of weeks.
>>>>>
>>>>> Right although I did give you feedback that what you sent wasn’t in a suitable form for review wrt Ada.
>>>>
>>>> Sure, but sending a patch set to gcc-patches wouldn't have worked either, we've got quite a strict
>>>> email size limit.
> 
> Note that the Ada part should have been quite limited in size given that the
> doc was already in .rst format, which is why I was expecting a smaller patch
> to review on the Ada side.

Yes, I made basically folder shuffling of the Ada files, but the .rst files itself were
mainly untouched. Plus, these was ambition having baseconf.py which would set-up common
settings for all Sphinx manuals.

> 
>>>> Anyway, hope the AdaCore build would be fixable with a reasonable amount of effort?
>>>
>>> Unclear yet. We'll probably need to change and possibly partially revert the
>>> Ada changes, we'll see.
>>
>> Hello.
>>
>> Note the Sphinx changes will be reverted today:
>> https://gcc.gnu.org/pipermail/gcc/2022-November/239983.html
>>
>> Sorry for your extra work.
> 
> Understood, thanks for your efforts and sorry you had to revert.

Thank you.

> 
> Clearly a change which requires a bleeding edge version of sphinx cannot be
> pushed at this stage, that's premature.

Yes, depending on bleeding edge version was of one the problem.

Cheers,
Martin

> 
> Cheers,
> 
> Arno


      reply	other threads:[~2022-11-14  8:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 13:47 Martin Liška
2022-11-11 17:25 ` Arnaud Charlet
2022-11-13 11:01   ` Martin Liška
2022-11-13 12:26     ` Arnaud Charlet
2022-11-13 13:36       ` Martin Liška
2022-11-13 17:03         ` Arnaud Charlet
2022-11-14  3:13           ` Martin Liška
2022-11-14  7:32             ` Arnaud Charlet
2022-11-14  8:20               ` Martin Liška [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fa2877d-03d4-d753-9a6c-2312d6f80952@suse.cz \
    --to=mliska@suse.cz \
    --cc=charlet@adacore.com \
    --cc=derodat@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=poulhies@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).