From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7C70D383578C for ; Mon, 14 Nov 2022 08:20:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C70D383578C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ADA031FCD9; Mon, 14 Nov 2022 08:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1668414024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uauDgPwurdVamqevHl0vI5bxPUNf18B6VPzU9MO9a44=; b=I3PtnQ/tFzUnlEfJ7v9tP3C4Oql+0KiYQPMgSuOqQEGHD8JvWcqG8U0zgW9uu0q6vbZCuJ Mn9k69yVuO/Ajxyo88xC6+ueOF/pUL16mYiQWjXPNHaohzH7v+z+oAMFgTqWRu/FpHrPHd sVtoWDfakdk2MdElzmE0bZfXAFIfd54= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1668414024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uauDgPwurdVamqevHl0vI5bxPUNf18B6VPzU9MO9a44=; b=7JvPStx5a4OjRFvIBvMWAjP3RcOwFZzO3Q0+pJqeIrZx/S5mmtY/giiqATwK9GCgChTuMz YRBdz5QfIYTXeUBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F30413A92; Mon, 14 Nov 2022 08:20:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jZ0EIkj6cWPKHgAAMHmgww (envelope-from ); Mon, 14 Nov 2022 08:20:24 +0000 Message-ID: <1fa2877d-03d4-d753-9a6c-2312d6f80952@suse.cz> Date: Mon, 14 Nov 2022 09:20:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] doc: Ada: include Indices and Tables in manuals To: Arnaud Charlet Cc: gcc-patches@gcc.gnu.org, Pierre-Marie de Rodat , Marc Poulhies References: <2c6b4a70-54d5-8463-2a0f-20f5d237ca65@suse.cz> <20221113170331.GA1702957@adacore.com> <2954855e-64ab-981b-3a17-bb6087ee0ecf@suse.cz> <20221114073235.GA1718056@adacore.com> Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20221114073235.GA1718056@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/22 08:32, Arnaud Charlet wrote: >>>>>> Sorry for the breakage. However, I contacted you (and your colleague) and haven't received >>>>>> any feedback for a couple of weeks. >>>>> >>>>> Right although I did give you feedback that what you sent wasn’t in a suitable form for review wrt Ada. >>>> >>>> Sure, but sending a patch set to gcc-patches wouldn't have worked either, we've got quite a strict >>>> email size limit. > > Note that the Ada part should have been quite limited in size given that the > doc was already in .rst format, which is why I was expecting a smaller patch > to review on the Ada side. Yes, I made basically folder shuffling of the Ada files, but the .rst files itself were mainly untouched. Plus, these was ambition having baseconf.py which would set-up common settings for all Sphinx manuals. > >>>> Anyway, hope the AdaCore build would be fixable with a reasonable amount of effort? >>> >>> Unclear yet. We'll probably need to change and possibly partially revert the >>> Ada changes, we'll see. >> >> Hello. >> >> Note the Sphinx changes will be reverted today: >> https://gcc.gnu.org/pipermail/gcc/2022-November/239983.html >> >> Sorry for your extra work. > > Understood, thanks for your efforts and sorry you had to revert. Thank you. > > Clearly a change which requires a bleeding edge version of sphinx cannot be > pushed at this stage, that's premature. Yes, depending on bleeding edge version was of one the problem. Cheers, Martin > > Cheers, > > Arno