public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] debug/110295 - mixed up early/late debug for member DIEs
Date: Mon, 19 Jun 2023 13:18:32 -0400	[thread overview]
Message-ID: <1fbbf155-ce44-450c-d4af-126012dedfaa@redhat.com> (raw)
In-Reply-To: <10678.123061906202700891@us-mta-531.us.mimecast.lan>

On 6/19/23 06:15, Richard Biener wrote:
> When we process a scope typedef during early debug creation and
> we have already created a DIE for the type when the decl is
> TYPE_DECL_IS_STUB and this DIE is still in limbo we end up
> just re-parenting that type DIE instead of properly creating
> a DIE for the decl, eventually picking up the now completed
> type and creating DIEs for the members.  Instead this is currently
> defered to the second time we come here, when we annotate the
> DIEs with locations late where now the type DIE is no longer
> in limbo and we fall through doing the job for the decl.
> 
> The following makes sure we perform the necessary early tasks
> for this by continuing with the decl DIE creation after setting
> a parent for the limbo type DIE.
> 
> [LTO] Bootstrapped on x86_64-unknown-linux-gnu.
> 
> OK for trunk?
> 
> Thanks,
> Richard.
> 
> 	PR debug/110295
> 	* dwarf2out.cc (process_scope_var): Continue processing
> 	the decl after setting a parent in case the existing DIE
> 	was in limbo.
> 
> 	* g++.dg/debug/pr110295.C: New testcase.
> ---
>   gcc/dwarf2out.cc                      |  3 ++-
>   gcc/testsuite/g++.dg/debug/pr110295.C | 19 +++++++++++++++++++
>   2 files changed, 21 insertions(+), 1 deletion(-)
>   create mode 100644 gcc/testsuite/g++.dg/debug/pr110295.C
> 
> diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc
> index d89ffa66847..e70c47cec8d 100644
> --- a/gcc/dwarf2out.cc
> +++ b/gcc/dwarf2out.cc
> @@ -26533,7 +26533,8 @@ process_scope_var (tree stmt, tree decl, tree origin, dw_die_ref context_die)
>   
>     if (die != NULL && die->die_parent == NULL)
>       add_child_die (context_die, die);

I wonder about reorganizing the function a bit to unify this parent 
setting with the one a bit below, which already falls through to 
gen_decl_die:

>       if (decl && DECL_P (decl))
>         {
>           die = lookup_decl_die (decl);
> 
>           /* Early created DIEs do not have a parent as the decls refer                                                             
>              to the function as DECL_CONTEXT rather than the BLOCK.  */
>           if (die && die->die_parent == NULL)
>             {
>               gcc_assert (in_lto_p);
>               add_child_die (context_die, die);
>             }
>         }

OK either way.

Jason


       reply	other threads:[~2023-06-19 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <10678.123061906202700891@us-mta-531.us.mimecast.lan>
2023-06-19 17:18 ` Jason Merrill [this message]
2023-06-20  7:01   ` Richard Biener
2023-06-19 10:15 Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fbbf155-ce44-450c-d4af-126012dedfaa@redhat.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).