From: Peter Bergner <bergner@linux.ibm.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, gcc-patches@gcc.gnu.org
Cc: hubicka@ucw.cz, Segher Boessenkool <segher@kernel.crashing.org>,
"Kewen.Lin" <linkw@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH v3] tree-profile: Disable indirect call profiling for IFUNC resolvers
Date: Wed, 3 Apr 2024 10:31:32 -0500 [thread overview]
Message-ID: <1fe1f320-95a1-4659-9031-29548fe1b3c0@linux.ibm.com> (raw)
In-Reply-To: <20240403124032.165069-1-hjl.tools@gmail.com>
On 4/3/24 7:40 AM, H.J. Lu wrote:
> We can't profile indirect calls to IFUNC resolvers nor their callees as
> it requires TLS which hasn't been set up yet when the dynamic linker is
> resolving IFUNC symbols.
>
> Add an IFUNC resolver caller marker to cgraph_node and set it if the
> function is called by an IFUNC resolver. Disable indirect call profiling
> for IFUNC resolvers and their callees.
The IFUNC resolvers on Power do not use TLS, so isn't this a little too
conservative? Should this be triggered via a target hook so architectures
that don't use TLS in their IFUNC resolvers could still profile them?
Peter
next prev parent reply other threads:[~2024-04-03 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 12:40 H.J. Lu
2024-04-03 13:38 ` Jan Hubicka
2024-04-03 13:49 ` H.J. Lu
2024-04-05 0:34 ` rep.dot.nop
2024-04-05 1:03 ` H.J. Lu
2024-04-05 7:02 ` rep.dot.nop
2024-04-03 15:31 ` Peter Bergner [this message]
2024-04-03 15:44 ` H.J. Lu
2024-04-03 15:45 ` Andrew Pinski
2024-04-03 16:16 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe1f320-95a1-4659-9031-29548fe1b3c0@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).