From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
To: mark@codesourcery.com (Mark Mitchell)
Cc: law@cygnus.com, gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org
Subject: Re: C++ Issue on GCC 3.0 branch
Date: Sat, 21 Apr 2001 16:05:00 -0000 [thread overview]
Message-ID: <200104212305.TAA10049@hiauly1.hia.nrc.ca> (raw)
In-Reply-To: <20010421123809V.mitchell@codesourcery.com>
> Weird. I actually get an abort on that code, compiling as you
> suggested. (I'm using a cross-compiler from i686-pc-linux-gnu.)
>
> What happens is that force_const_mem records constant-pool entries for
> labels here, from expand_builtin_setjmp_setup:
>
> emit_move_insn (validize_mem (mem),
> force_reg (Pmode, gen_rtx_LABEL_REF (Pmode, receiver_label)));
>
> Then, flow deletes the labels. Then, when output_constant_pool goes
> to output the reference, this abort files:
>
> case LABEL_REF:
> tmp = XEXP (x, 0);
> if (INSN_DELETED_P (tmp)
> || (GET_CODE (tmp) == NOTE
> && NOTE_LINE_NUMBER (tmp) == NOTE_INSN_DELETED))
> {
> abort ();
> x = const0_rtx;
> }
>
> What's supposed to keep that from happenning?
How about this?
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
2001-04-21 John David Anglin <dave@hiauly1.hia.nrc.ca>
* builtins.c (expand_builtin_setjmp_setup): Set nonlocal flag in label.
--- builtins.c.orig Tue Apr 17 14:26:59 2001
+++ builtins.c Sat Apr 21 18:41:27 2001
@@ -468,6 +468,7 @@
enum machine_mode sa_mode = STACK_SAVEAREA_MODE (SAVE_NONLOCAL);
rtx stack_save;
rtx mem;
+ rtx label_ref;
if (setjmp_alias_set == -1)
setjmp_alias_set = new_alias_set ();
@@ -495,8 +496,9 @@
mem = gen_rtx_MEM (Pmode, plus_constant (buf_addr, GET_MODE_SIZE (Pmode))),
MEM_ALIAS_SET (mem) = setjmp_alias_set;
- emit_move_insn (validize_mem (mem),
- force_reg (Pmode, gen_rtx_LABEL_REF (Pmode, receiver_label)));
+ label_ref = gen_rtx_LABEL_REF (Pmode, receiver_label);
+ LABEL_REF_NONLOCAL_P (label_ref) = 1;
+ emit_move_insn (validize_mem (mem), force_reg (Pmode, label_ref));
stack_save = gen_rtx_MEM (sa_mode,
plus_constant (buf_addr,
next parent reply other threads:[~2001-04-21 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010421123809V.mitchell@codesourcery.com>
2001-04-21 16:05 ` John David Anglin [this message]
[not found] <no.id>
2001-04-21 19:33 ` John David Anglin
2001-04-23 2:18 ` Bernd Schmidt
2001-04-23 7:51 ` law
2001-04-23 7:55 ` Bernd Schmidt
2001-04-23 7:56 ` Bernd Schmidt
2001-04-23 8:14 ` law
2001-04-25 10:26 ` Mark Mitchell
2001-04-25 14:04 ` John David Anglin
2001-04-25 17:31 ` Mark Mitchell
2001-04-26 8:32 ` John David Anglin
2001-04-26 10:25 ` Mark Mitchell
2001-04-26 10:02 ` law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200104212305.TAA10049@hiauly1.hia.nrc.ca \
--to=dave@hiauly1.hia.nrc.ca \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=law@cygnus.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).